mirror of
https://git.freebsd.org/ports.git
synced 2025-05-13 07:41:50 -04:00
In Python 3.4+, upstream added and switched to using a shell implementation of the python-config script [1]. The Python implementation (python-config.py) remained used by all versions < 3.4. While the shell implementation returns the path to the Python shared library when using the --ldflags script argument, the Python implementation of the script does not. The bug has been reported, but has not yet been merged [2]. The Python ports currently default to including ${LOCALBASE}/lib in LIBS when the NLS option is enabled (which it is by default). When built *with* NLS (gettext) support, the flags added to LIBS are returned in `pythonX.Y-config --ldflags` output, which happens to match the path to the Python shared library. If the NLS option is disabled, ${LOCALBASE}/lib is not added to LIBS, and are therefore not returned in --ldflags output. This results in potential linking errors for software that uses python-config to obtain the correct library path, when the NLS option is disabled: $ make WITH=PYTHON -C audio/alsa-lib [...] --- smixer-python.la --- CCLD smixer-python.la /usr/bin/ld: cannot find -lpython2.7 This change modifies the python-config.in script to match the shell implementation, outputting the library path in --ldflags output. While I'm here: for Python 3.2 and Python 3.3 ports, backport a library order change [3]. This could affect linking with static libraries. Use standard length lines and reduce diffs in pkg-message [1] https://bugs.python.org/issue16235 [2] https://bugs.python.org/issue7352 [2] https://bugs.python.org/issue18096 PR: 197757 Submitted by: jbeich MFH: 2015Q4
21 lines
776 B
Text
21 lines
776 B
Text
# pythonx.y-config --ldflags out of /usr and missing -L<install_lib_dir>
|
|
# https://bugs.python.org/issue7352
|
|
|
|
--- Misc/python-config.in.orig 2015-10-18 07:24:01 UTC
|
|
+++ Misc/python-config.in
|
|
@@ -21,6 +21,7 @@ except getopt.error:
|
|
if not opts:
|
|
exit_with_usage()
|
|
|
|
+libdir = sysconfig.EXEC_PREFIX + '/lib'
|
|
pyver = sysconfig.get_config_var('VERSION')
|
|
getvar = sysconfig.get_config_var
|
|
|
|
@@ -50,6 +51,7 @@ for opt in opt_flags:
|
|
# add the prefix/lib/pythonX.Y/config dir, but only if there is no
|
|
# shared library in prefix/lib/.
|
|
if opt == '--ldflags':
|
|
+ libs.insert(0, '-L' + libdir)
|
|
if not getvar('Py_ENABLE_SHARED'):
|
|
libs.insert(0, '-L' + getvar('LIBPL'))
|
|
if not getvar('PYTHONFRAMEWORK'):
|