mirror of
https://git.freebsd.org/ports.git
synced 2025-06-15 01:30:33 -04:00
76 lines
2.1 KiB
Diff
76 lines
2.1 KiB
Diff
From d9b748869a8f4018ebee302aae8246bf29f60309 Mon Sep 17 00:00:00 2001
|
|
From: "Timur I. Bakeyev" <timur@iXsystems.com>
|
|
Date: Fri, 1 Jun 2018 01:35:08 +0800
|
|
Subject: [PATCH 1/2] vfs_fruit: allow broken AFP_Signature where the first
|
|
byte is 0
|
|
|
|
FreeBSD bug ... caused the first byte of the AFP_AfpInfo xattr to be 0
|
|
instead of 'A'. This hack allows such broken AFP_AfpInfo blobs to be
|
|
parsed by afpinfo_unpack().
|
|
|
|
FreeBSD Bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228462
|
|
|
|
Signed-off-by: Ralph Boehme <slow@samba.org>
|
|
---
|
|
source3/modules/vfs_fruit.c | 32 ++++++++++++++++++++++++--------
|
|
1 file changed, 27 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
|
|
index df3cd0c899e..d84e6991036 100644
|
|
--- a/source3/modules/vfs_fruit.c
|
|
+++ b/source3/modules/vfs_fruit.c
|
|
@@ -2350,6 +2350,8 @@ static ssize_t afpinfo_pack(const AfpInf
|
|
return AFP_INFO_SIZE;
|
|
}
|
|
|
|
+#define BROKEN_FREEBSD_AFP_Signature 0x00465000
|
|
+
|
|
/**
|
|
* Unpack a buffer into a AfpInfo structure
|
|
*
|
|
@@ -2369,10 +2371,20 @@ static AfpInfo *afpinfo_unpack(TALLOC_CT
|
|
memcpy(ai->afpi_FinderInfo, (const char *)data + 16,
|
|
sizeof(ai->afpi_FinderInfo));
|
|
|
|
- if (ai->afpi_Signature != AFP_Signature
|
|
- || ai->afpi_Version != AFP_Version) {
|
|
- DEBUG(1, ("Bad AfpInfo signature or version\n"));
|
|
+ if (ai->afpi_Signature != AFP_Signature) {
|
|
+ DBG_WARNING("Bad AFP signature [%x]\n", ai->afpi_Signature);
|
|
+
|
|
+ if (ai->afpi_Signature != BROKEN_FREEBSD_AFP_Signature) {
|
|
+ DBG_ERR("Bad AfpInfo signature\n");
|
|
+ TALLOC_FREE(ai);
|
|
+ return NULL;
|
|
+ }
|
|
+ }
|
|
+
|
|
+ if (ai->afpi_Version != AFP_Version) {
|
|
+ DBG_ERR("Bad AfpInfo version\n");
|
|
TALLOC_FREE(ai);
|
|
+ return NULL;
|
|
}
|
|
|
|
return ai;
|
|
@@ -4171,9 +4183,20 @@ static ssize_t fruit_pread_meta_stream(v
|
|
{
|
|
ssize_t nread;
|
|
int ret;
|
|
+ char *p = (char *)data;
|
|
|
|
nread = SMB_VFS_NEXT_PREAD(handle, fsp, data, n, offset);
|
|
- if (nread == -1 || nread == n) {
|
|
+
|
|
+ if (nread == -1) {
|
|
+ return -1;
|
|
+ }
|
|
+
|
|
+ if (nread == n) {
|
|
+ if (offset == 0 && nread > 3 && p[0] == 0 && p[1] == 'F' && p[2] == 'P') {
|
|
+ DBG_NOTICE("Fixing AFP_Info of [%s]\n",
|
|
+ fsp_str_dbg(fsp));
|
|
+ p[0] = 'A';
|
|
+ }
|
|
return nread;
|
|
}
|
|
|