Commit graph

145 commits

Author SHA1 Message Date
Yuri Victorovich
6af95e9e48 Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries
Reason: 'grep -q SONAME' ends before it drains the pipe, pipe fails
when the remaining output is too long, and 'set -o pipefail'
causes the whole command to fail when it is supposed to succeed.

Remedy: Please apply the attached patch fix-SONAME.patch, or
alternatively remove 'set -o pipefail' from qa.sh

PR:		259992
Approved by:	tcberner@ (as portmgr)
2022-07-09 07:52:33 -07:00
Dmitri Goutnik
3012ca2179 */*: Introduce versioned Go ports
- Mk/Uses/go.mk: add support for selecting Go port version in USES=go;
- Mk/bsd.default-versions.mk: add GO_DEFAULT;
- convert lang/go-devel to the master and lang/go{117,118} to slave
  ports;
- add lang/go meta-port that provides go and gofmt symlinks to the
  current default version.

PR:		264336
Reviewed by:	ygy jwb yuri mikael drtr0jan@yandex.ru decke mat
Differential Revision:	https://reviews.freebsd.org/D35346
2022-06-06 13:19:10 -05:00
Tobias C. Berner
e250aeb4a1 KDE: Update KDE Gear to 22.04
Thursday, 21 April 2022

Welcome to KDE Gear ⚙️ 22.04!

Skip to What’s New

KDE Gear ⚙️ 22.04 brings you all the updates added to a long list of KDE
apps over the last four months. KDE programs allow you to work, create
and play without having to submit yourself to extortionate licenses and
intrusive advertising, or surrender your privacy to unscrupulous
corporations.

Below you will discover a selection of the changes added in the last
four months to software designed to make your life better. But remember,
there is much, much more: games, social media apps, utilities for
communicating, developing and creating stuff… All these things have been
worked on to give you more stability and boost your productivity.

If you want to see a full list of everything we have done, check out the
complete changelog.

WARNING: There’s a lot!

All the details can be found here:
	https://kde.org/announcements/gear/22.04.0/
2022-04-21 13:26:44 +02:00
Baptiste Daroussin
1bc4afd4b4 devel/ORBit2: remove gnome2 library 2022-03-15 20:16:13 +01:00
Dan Langille
7b279c9e09 devel/ruby-gems: Update to 3.3.7
These are fixes Ruby 3.0

Changes were compiled against all dependencies of devel/ruby-gems and
they all built cleanly.

There are five known build failures, all prexisting:

* devel/rubygem-xdg5: requires Ruby 3.0
* devel/rubygem-xdg: requires Ruby 3.1
* graphics/rubygem-objectdetect: port explicitly marked broken
* mail/rubygem-tmail: port explicitly marked broken
* science/cdcl: marked broken, unfetchable

Plus, science/rubygem-ruby-dcl gets skipped because of science/cdcl

PR:		258108
Approved by:	ruby (zi@)
2022-02-20 13:06:12 +00:00
Tobias C. Berner
45526ecbee framework: Add new USES 'magick' for graphics/ImageMagick*
A new USES has been added to depend on ImageMagick.

	USES=magick

adds a LIB_DEPENDS on graphics/ImageMagick${IMAGEMAGICK_DEFAULT}.

If a specific version is required, use for example

	USES=magick:6        resp.     USES=magick:7

If only a build, run or test is required, use for example

	USES=magick:build    resp.     USES=magick:6,build,test

If a dependency on the nox11 flavor is required, use for example

	USES=magick:nox11    resp.     USES=magick:7,nox11,run,test

See magick.mk for more details on the available flags.

The tree has been completely converted to make use of this.

Approved by:	bapt
Differential Revision: https://reviews.freebsd.org/D32754
2021-12-11 14:50:53 +01:00
Joseph Mingrone
6ff48ecff7
Mk/Scripts/qa.sh: Turn off pipefail when piping to grep -q
The pipeline

   readelf -d "${dep_file}" | grep -q SONAME

can fail because grep -q closes the output early resulting sigpipe being
sent to readelf.  Other possible solutions are to turn off pipefail for
the file or remove the -q grep argument.

Credit to ashish@ for the detective work to discover the root cause of
this.

Differential Revision: https://reviews.freebsd.org/D31211

Reviewed by:	emaste
Approved by:	bapt (portmgr) mat (portmgr)
2021-11-19 17:13:26 -04:00
Kevin Bowling
b5a56c9450 Mk/Scripts/qa.sh: Add QA for libglvnd
Reported by:	tcbrener
Reviewed by:	tcbrener
Differential Revision:	https://reviews.freebsd.org/D31375
2021-08-02 09:20:45 -07:00
Li-Wen Hsu
09704c68fc
Mk/: Update the URLs in the comments to the latest location
Reviewed by:	rene
Differential Revision: https://reviews.freebsd.org/D31152
2021-07-16 16:16:45 +08:00
Baptiste Daroussin
9c23cce831 devel/libbonobo: remove
Gnome2 lib, dead upstream, no consumers left in the ports tree
2021-05-01 23:00:05 +02:00
Baptiste Daroussin
8e6f2eb82e devel/gnome-vfs: remove
Dead upstream, no consumers left in the ports tree
2021-05-01 15:29:37 +02:00
Baptiste Daroussin
e9cac8e2ce x11/libgnome: remove
Gnome2 library dead upstream with no consumers left in the ports tree
2021-05-01 15:26:12 +02:00
Baptiste Daroussin
eaec3af059 Mk/*: cleanup leftovers from ancient removal 2021-05-01 14:58:26 +02:00
Baptiste Daroussin
b391fefab5 qa.sh: adjust after removal of some gnome ports 2021-05-01 14:47:33 +02:00
Mathieu Arnold
5d33e04596
framework: Remove $FreeBSD$
Where appropriate fiddle with a few other things.
2021-04-06 16:27:10 +02:00
Olivier Cochard
578eb55645 Allows atf scripts to pass qa
Approved by:	rene
Sponsored by:	Netflix
Differential Revision:	https://reviews.freebsd.org/D28581
2021-03-08 14:11:44 +00:00
Gerald Pfeifer
b2e6ef7f3b Revert r562049 which I committed by mistake.
Pointy hat:	gerald
2021-01-19 15:04:17 +00:00
Gerald Pfeifer
db1e3fae20 GCC_DEFAULT now sits at 10, so remove the special setting we added for
powerpc64le which is a nop now (essentially reverting revision 559637).

Reported by:	pkubaj
2021-01-19 15:02:22 +00:00
Rene Ladan
8a45ee228f Remove graphics/jpeg which has expired in favor of graphics/jpeg-turbo
Update qa checks and add a note to UPDATING to help users migrate.
Differential Revision:	https://reviews.freebsd.org/D27425
2020-12-01 19:12:47 +00:00
Mathieu Arnold
292183dbc4 Ignore readelf's return value.
PR:		251110 (with style fixes)
Submitted by:	John Hein
2020-11-16 10:50:54 +00:00
Mathieu Arnold
f916081e1c Add set pipefail in most framework scripts.
set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.

PR:		250723
Exp-run by:	antoine
Reviewed by:	bapt
Approved by:	bapt
Differential Revision:	https://reviews.freebsd.org/D27007
2020-11-11 13:29:52 +00:00
Tobias C. Berner
9e0e8d17a4 Prefer graphics/ligvrsvg2-rust over graphics/librsvg2
- switch to the more modern version of librsvg2 on architectures
  supporting rust
- this will fix some graphical issues on these architectures

PR:		250276
Exp-run by:	antoine
Submitted by:	tobik
Differential Revision:	https://reviews.freebsd.org/D18878
2020-11-09 17:08:12 +00:00
Mathieu Arnold
aeda355b1b Backout r554139. 2020-11-05 16:51:30 +00:00
Mathieu Arnold
e9b2078c6c Add set pipefail in most framework scripts.
set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.
2020-11-05 16:42:35 +00:00
Tobias C. Berner
0edfaee1ed KDE's August 2020 Apps Update
Dozens of KDE apps are getting new releases from KDE’s release service. New
features, usability improvements, re-designs and bug fixes all contribute to
helping boost your productivity and making this new batch of applications more
efficient and pleasant to use.

Full announcement:
        https://kde.org/announcements/releases/2020-08-apps-update/
2020-08-13 17:10:30 +00:00
Ryan Steinmetz
178b0490c2 - Update wording/style on REINPLACE_CMD checks 2020-08-03 13:46:11 +00:00
Tobias C. Berner
89fc0f48dc Update KDE Framewokrs to 5.72
July 04, 2020. KDE today announces the release of KDE Frameworks 5.72.0.

KDE Frameworks are over 70 addon libraries to Qt which provide a wide variety
of commonly needed functionality in mature, peer reviewed and well tested
libraries with friendly licensing terms. For an introduction see the KDE
Frameworks web page.

This release is part of a series of planned monthly releases making
improvements available to developers in a quick and predictable manner.

Changelog:
	https://kde.org/announcements/kde-frameworks-5.72.0.php?site_locale=en

- net/kdav became a framework and was therefore moved to net/kf5-kdav.
- thanks to adridg@ for fixing the fallout

Exp-run by:	antoine
PR:		247907
2020-07-21 17:15:38 +00:00
Dan Langille
c1f39c706a At present, the policy implemented in Mk/Scripts/qa.sh prevents me
from adding lang/python, lang/python2, or lang/python3 as a dependency of
another port. "This is to prevent adding dependencies to meta ports that
are only there to improve the end user experience." - I build my own packages
via poudriere. I want to create my own meta-package which has such packages
as RUN_DEPENDS. It's been suggested that I patch my own copy of the tree.
This patch moves towards tools, not policy.

This patch allows me to set this variable in a poudriere make.conf file:

QA_ENV+= IGNORE_DEPENDS_BLACKLIST="YES"

Reviewed by:	mat
Approved by:	portmgr
Differential Revision:	https://reviews.freebsd.org/D25450
2020-07-20 19:22:16 +00:00
Steve Wills
0a82a7c091 Add QA warning about useless REINPLACE_CMD
Reviewed by:	mat, bdrewery, tobik
Approved by:	mat
Differential Revision:	https://reviews.freebsd.org/D22174
2020-01-09 13:01:45 +00:00
Baptiste Daroussin
c2ca919129 Garbage collect libgnomeprint 2019-12-26 21:46:02 +00:00
Baptiste Daroussin
a472a290be Add make to the list of allowed shebang
PR:		228874
Reported by:	jwb
2019-09-06 08:57:12 +00:00
Rene Ladan
85ce2bc6f6 Remove USES=pure and its QA check now that lang/pure has been removed. 2019-09-01 15:54:18 +00:00
Mathieu Arnold
55b249bab3 Add a QA check warning porters about non UCL pkg-message files.
Reviewed by:	adamw
Differential Revision:	https://reviews.freebsd.org/D21262
2019-08-19 12:18:21 +00:00
Antoine Brodin
fa22bcefd1 Add lang/julia to the blacklist of ports that other ports must not depend upon.
With hat:	portmgr
2019-05-28 09:44:05 +00:00
Rene Ladan
dfd801cad1 Remove esound support from the ports tree, as audio/esound expired. 2019-05-08 12:54:13 +00:00
Tobias C. Berner
c5584049b0 qa.sh: update KDE components
- synchronize the list of components
- update the comment on how to generate the components for the now kde- prefixed names
- remove the now unnecessary part about Qt4

Reviewed by:	yuri
Approved by:	portmgr (rene)
Differential Revision:	https://reviews.freebsd.org/D19894
2019-04-13 17:05:45 +00:00
Mathieu Arnold
a29c880f74 Add a blacklist of ports that other ports must not depend upon.
Those ports are meta ports, and are only there to improve the user's
experience, in which, if they want, say, python or gcc, they do not have
to figure out what version they should be installing, they simply
install python or gcc.

Reviewed by:	antoine
Approved by:	adamw
Differential Revision:	https://reviews.freebsd.org/D19562
2019-03-18 15:59:13 +00:00
Tobias Kortkamp
69fbf6bed7 Mk/Scripts/qa.sh: Remove glib12 and gtk12
Approved by:	portmgr (bapt)
Differential Revision:	https://reviews.freebsd.org/D19055
2019-02-01 16:43:37 +00:00
Mathieu Arnold
3642a3436f Fix proxydeps QA check when multiple flavor of a package are installed.
Previously it would do this:

$ pkg which -q -o /usr/local/lib/libphonon4qt5.so
multimedia/phonon
$ pkg pkg annotate -q -S multimedia/phonon flavor
qt4
qt5

And that would break things in an interesting way.

This changes makes it use the package name of the required file, which
is unique.

Note that this problem would probably only ever happen on a live system.
I was not able to find a single port that would trigger this it in a
clean environment (poudriere testport).

PR:		231332
Submitted by:	dbn
2019-01-11 12:50:51 +00:00
Mathieu Arnold
dc820c0194 Remove obsolete qa check. 2018-12-17 14:29:41 +00:00
Mathieu Arnold
35326f1a97 security/openssl-devel was removed, but there is a security/openssl111 now. 2018-11-10 10:09:48 +00:00
Sunpoet Po-Chuan Hsieh
6dd23db065 Fix typo
Differential Revision:	https://reviews.freebsd.org/D17263
Approved by:	bapt (portmgr)
2018-09-22 16:45:47 +00:00
Mathieu Arnold
7256d8f2f7 Tell people who disabled LICENSE processing that it then cannot be
checked.

Reported by:	mfechner
Approved by:	bapt
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D16450
2018-07-26 10:37:36 +00:00
Mathieu Arnold
1e5af0bf74 Have the license qa check actually work.
Pointy hat:	mat
Sponsored by:	Absolight
2018-07-18 11:33:24 +00:00
Mathieu Arnold
f305cacf3a Add a license qa check to tell porters when their ports will be mostly
useless.

Reviewed by:	antoine
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D16103
2018-07-18 11:13:06 +00:00
Tobias C. Berner
b1a1d38bf9 Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk
From now on, ports that depend on Qt4 will have to set
	USES=		qt:4
	USE_QT=		foo bar
ports depending on Qt5 will use
	USES=		qt:5
	USE_QT=		foo bar

PR:		229225
Exp-run by:	antoine
Reviewed by:	mat
Approved by:	portmgr (antoine)
Differential Revision:	→https://reviews.freebsd.org/D15540
2018-06-28 17:39:53 +00:00
Mathieu Arnold
b19fe1e937 SC1004: This backslash+linefeed is literal. Break outside single quotes if you just want to break the line.
You have a single quoted string containing a backslash followed by a
linefeed (newline). Unlike double quotes or unquoted strings, this has
no special meaning. The string will contain a literal backslash and a
linefeed.

If you wanted to break the line but not add a linefeed to the string,
stop the single quote, break the line, and reopen it.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
2018-06-08 09:26:41 +00:00
Mathieu Arnold
b234bfd716 SC2162: read without -r will mangle backslashes.
By default, read will interpret backslashes before spaces and line
feeds, and otherwise strip them. This is rarely expected or desired.

Normally you just want to read data, which is what read -r does. You
should always use -r unless you have a good reason not to.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
2018-06-08 09:26:34 +00:00
Mathieu Arnold
ac5e64ba02 SC2015: Note that A && B || C is not if-then-else. C may run when A is true.
It's common to use A && B to run B when A is true, and A || C to run C
when A is false.

However, combining them into A && B || C is not the same as if A then B
else C.

In this case, if A is true but B is false, C will run.

If an if clause is used instead, this problem is avoided.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
2018-06-08 09:26:31 +00:00
Mathieu Arnold
bf064c8390 SC2006: Use $(..) instead of legacy ...
Backtick command substitution `STATEMENT` is legacy syntax with several
issues.

 - It has a series of undefined behaviors related to quoting in POSIX.
 - It imposes a custom escaping mode with surprising results.
 - It's exceptionally hard to nest.

$(STATEMENT) command substitution has none of these problems, and is
therefore strongly encouraged.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
2018-06-01 16:20:54 +00:00