services using the same script. As a result it resets rcvar several times
in order to process the options for each service.
The changes I made on 2012/01/14 to facilitate the removal of set_rc_var()
from HEAD were effective in the case where the WINBIND option was off (the
case that I tested) because that causes the related portions of the rc.d
script to be removed completely on install. However, if installed from a
package, or installed using the the default OPTIONS, WINBIND is on, which
caused the last known rcvar to be winbind_enable.
Since the common case seems to be for users to use samba_enable (which
only enables smb_and nmb_ by default) the fact that rcvar=winbind_enable,
but that knob is off, caused the startup script to trip on a totally
unrelated portion of rc.subr.
So the fix is to move processing of the winbind_ stuff first, which leaves
the last known rcvar as smb_enable. Since running nmb without smb is a
very unlikely scenario, this should be safe for the common case, as well
as safe if the user enables winbind_.
Apologies all around for not catching this sooner, and thanks to the users
who reported the problem and stuck with me while I debugged it.
Bump PORTREVISION since this fix is needed for the common case, as
configured for the package.
(CVE-2012-1182):
- Update samba36 to 3.6.4;
- Update samba35 to 3.5.14;
- Update samba34 to 3.4.16;
All samba users are advised to update.
Security: baf37cd2-8351-11e1-894e-00215c6a37bb
With hat: secteam@
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().
In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.
Major enhancements in Samba 3.4.8 include:
o Fix Winbind reconnection to it's own domain (bug #7295).
o Fix an uninitialized variable read in smbd (bug #7254).
o Fix smbd crash with CUPS printers and no [printers] share defined
(bug #7297).
o Fix NULL pointer dereference in smbd (bug #7229).
