Commit graph

2 commits

Author SHA1 Message Date
Tijl Coosemans
8b413af5b1 Improve the FreeBSD SCSI and SAS support in smartmontools:
- Remove unused private fields from some classes (found by Clang).
- In freebsd_scsi_device::scsi_pass_through:
  * Make sure this function returns false on error instead of an error
    code that gets converted to true.
  * Put printing of the "Incoming data" debug info right after the
    cam_send_ccb() call and before the error checking to make
    debugging easier.
  * When copying sense data make sure the fields in the CCB are
    actually valid with CAM_AUTOSNS_VALID.  Also make sure that the
    size of the sense data doesn't overflow max_sense_len.  This was
    the real cause for the crash in ports/181836.
  * Add some debug printing on the sense data.

Committed upstream as r3873.

PR:		ports/181836, ports/185960, ports/186095
Tested by:	many
2014-03-03 18:58:14 +00:00
Tijl Coosemans
f7481ef696 - Fix a crash with some SCSI disks.
- Add DOCS option and use option helpers.
- USES=gmake.
- Staging.
- Remove CFLAGS left from old versions.

PR:		ports/181836
Approved by:	maintainer timeout (3 weeks)
2014-01-17 09:31:42 +00:00