PR: 192881
Submitted by: Chris Hutchinson
I am sure many people wanted to see this port die, but Chris wanted to
save it. Unfortunately his PR only contained about 2% of the work needed
to properly stage it. I had to overhaul it with the changes to numerous
to recount. Some big ticket items: converted to OptionsNG the EMACS and
CLIENT_ONLY knobs (the ability to define the exact EMACS version is lost,
it just takes the default. There are only 2 EMACS versions anyway).
The chown/mode changes where moved from vendor makefile to pkg-plist. I
also leveraged @sample keyword for the two conf files.
gnats/gnats.h contains its own prototypes of asprintf() and vasprintf()
which conflict with the system ones:
In file included from edit.c:21:
./gnats.h:140:12: error: conflicting types for 'asprintf'
extern int asprintf (char **buf, const char *fmt, ...);
^
/usr/include/stdio.h:396:6: note: previous declaration is here
int asprintf(char **, const char *, ...) __printflike(2, 3);
Just remove the prototypes from gnats.h.
Reported by: miwi@
The following patch will fix this.
A local gnats mirror is often the only way to rip out patches in a
format which is usefull for further PR handling / patching, so it will be
nice if the default database type does match the upstream (gnats-freebsd).
Maybe this trivial fix helps even others to move from gnats to gnats4
PR: ports/159947
Submitted by: ohauer
Approved by: maintainer timeout (vd ; 175 days)
