Commit graph

90 commits

Author SHA1 Message Date
Matthias Andree
87f0f372e4 mail/mailman: 2.1.38 security fixing CSRF vuln
While here, fix pkg-message to mention -exim4 and -postfix
derived ports that override the default MTA.

Security:	0d6efbe3-52d9-11ec-9472-e3667ed6088e
Security:	CVE-2021-44227
MFH:		2021Q4
2021-12-01 20:09:46 +01:00
Mathieu Arnold
135fdeebb9
all: Remove all other $FreeBSD keywords. 2021-04-06 16:31:13 +02:00
Matthias Andree
a36309afca mail/mailman: update to 2.1.34 (bugfixes)
Changelog:
http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/view/1859/NEWS#L8

(Note the ValueError fix was already in FreeBSD's 2.1.33_1 and
- on quarterly - the 2.1.30_5 port/package versions.)

Follow POLA:
No MFH requested, as 2020Q2 and head/ have diverged too far,
so let 2020Q3 pick up the change instead.
2020-06-28 10:04:47 +00:00
Matthias Andree
2c4c04854b mail/mailman: cherry-pick regression fix from upstream
https://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1850#NEWS
https://launchpad.net/bugs/1878458

Obtained from:	Mark Sapiro
MFH:		2020Q2 (blanket for minimal bug fixes)
2020-05-16 09:04:16 +00:00
Matthias Andree
a00aaa6892 mail/mailman: update to 2.1.32
- fixes the i18n issues in 2.1.31
  - drop local patch for Spanish Castilian mailman.po file
  - drop local REINPLACE_CMD for translations of the security fixed code

- uses a patch from the upstream merged rev 1814 of the htdig branch
2020-05-06 22:56:26 +00:00
Matthias Andree
0c70c1305e mail/mailman: security update to 2.1.31
Over the upstream 2.1.31, additional fixes were needed:
+ fix up quoting in one string of the messages/es/ translation
  to unbreak gettext
+ fix up all */LC_MESSAGES/mailman.po to match up with the security fix.

Upstream Changelog for 2.1.31, cited from
<https://bazaar.launchpad.net/~mailman-coders/mailman/2.1/view/1845/NEWS#L8>:
Security
    - A content injection vulnerability via the options login page has been
      discovered and reported by Vishal Singh. This is fixed.  (LP: #1873722)
i18n
    - The Spanish translation has been updated by Omar Walid Llorente.
Bug Fixes and other patches
    - Bounce recognition for a non-compliant Yahoo format is added.
    - Archiving workaround for non-ascii in string.lowercase in some Python
      packages is added.

MFH:		2020Q2
Security:	88760f4d-8ef7-11ea-a66d-4b2ef158be83
2020-05-05 18:00:30 +00:00
Matthias Andree
cccf793012 mail/mailman: rcfile and pkg-message tweaks
Limit the install message about pkg install -I to installs (not upgrades).

Convert the required_dirs of the rcfile into a coded prereq check,
so that we can print the proper error message, and point the user to
the right place.

Bump PORTREVISION.
2020-04-27 18:04:58 +00:00
Matthias Andree
b337c05a03 mail/mailman: fix some permission issues, realign template policy
- tighten up permissions on install dirs even more, patching
  bin/check_perms to not complain - fewer directories or files belong
  in mailman's hand or need group write permissions.

- revert 2.1.30's "make templates samples" because the upstream has
  always instead provided a templates/site dir here and warned users that
  default templates will be overwritten on updates or reinstallation
  https://wiki.list.org/DOC/4.48%20How%20can%20I%20change%20the%20HTML%20or%20.txt%20templates%20used%20by%20my%20mailing%20lists%3F
  changed templates will be written to different directories, the site,
  domain-specific or list-specific directory

- adjust pkg-plist such that a no-script install, a regular install
  with post-install script run, and check_perms agree on permissions,
  however with tighter write permissions than the default install,
  as a security-in-depth safety precaution. [1]

- revise files/pkg-install.in accordingly

- boil down files/pkg-message.in texts a little bit

- bump PORTREVISION

PR:		245853
Reported by:	manu@ (IRC) [1]
2020-04-25 22:41:21 +00:00
Matthias Andree
deeaf0e960 mail/mailman: update to 2.1.30 - bug fix (incl. data loss)
* upstream changelog:
https://bazaar.launchpad.net/~mailman-coders/mailman/2.1/view/head:/NEWS#L6

Note that upstream means 2.1.30 to be the final 2.x release,
because it relies on Python 2.x which is EOL upstream.

! MAJOR DATA LOSS FIX, rename all templates/* files to .sample,
! and list them as a @sample in pkg-plist, because they can be edited
! through the web server, and an upgrade should not stomp over edited files.

* rearrange makefile a bit (portlint, portfmt)
* update and upload new htdig patch
* expose NLS port option to pkg-install script to avoid failure
* patch upstream bin/check_perms script to not complain about tightened-
  up messages/ and mailmanprefix (${PREFIX}/mailman) permissions that we
  set to 0755 instead of 02775. Mailman should not need to write outside
  designated directories or create new top-level directories in its install.
* fix a typo in the German (mailman.po) translation
* tweak pkg-install to:
  - leave ${PREFIX}/mailman permissions alone and not set them to 02775
  - fix up non-moved .sample files if pkg-install is run with -I
  - create a copy of mm_cfg.py from mm_cfg.py.dist if missing (-I)
  - create a newsyslog.conf.d/mailman.conf if missing, from
    examples/mailman.newsyslog.sample if installed (-I)
  - not attempt to fix messages/ (translations) permissions if the NLS
    port option is disabled
* tweak pkg-plist so that the proper permissions and groups are set
  by default already
* clean up pkg-message, thanks to bapt@ for pointing out that a missing
  type: means "install or upgrade".

MFH:		2020Q2 (@samples is an important fix against data loss on update)
2020-04-14 20:46:25 +00:00
Matthias Andree
0e08f2ef68 mail/mailman: repair incomplete UCL conversion of pkg-message.in
There are parts of the install message that are also relevant on
updates, but were missed. Add them, and bump PORTREVISION.

Failure-inducing commit:

------------------------------------------------------------------------
r508882 | mat | 2019-08-14 00:29:42 +0200 (Wed, 14 Aug 2019) | 2 lines

onvert to UCL & cleanup pkg-message (categories l-m)

------------------------------------------------------------------------
2020-04-12 02:39:52 +00:00
Mathieu Arnold
558224994b onvert to UCL & cleanup pkg-message (categories l-m) 2019-08-13 22:29:42 +00:00
Matthias Andree
b254f6fa37 Actually expand newsyslog locations in pkg-message.
Followup to
Differential Revision:	https://reviews.freebsd.org/D17088
2018-11-29 17:34:54 +00:00
Ben Woods
898fbce0b3 mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
- Rename the files installed to /usr/local/etc/newsyslog.conf.d/ to end
  with a '.conf' suffix.
- Add pkg-install script to automatically move any copies of the old
  newsyslog file to the new location if the new file is unmodified from the default,
  or print a warning if it the new file has been modified.
- Add a note to UPDATING and pkg-message to warn users of this, in case
  they are using provisioning/configuration management tools which need
  to be modified. Note the UPDATING entry was committed in r485721.

Recent changes to /etc/newsyslog.conf (r340318) will only include files
from the /usr/local/etc/newsyslog.conf.d/ directory which end with
'.conf' and do not beginning with a '.' character.

Reviewed by:	mat
Approved by:	mandree (maintainer)
Differential Revision:	https://reviews.freebsd.org/D17088
2018-11-28 14:18:08 +00:00
Kurt Jaeger
51fd52e04f mail/mailman: add OPTION to not send passwords in the monthly mails
- this option is now on by default

PR:		231879
Reported by:	several users
Approved by:	mandree
Obtained from:	https://mail.python.org/pipermail/mailman-users/2016-April/080746.html
MFH:		2018Q4
2018-11-02 14:17:35 +00:00
Matthias Andree
3273e9a5b7 Security upgrade mail/mailman to v2.1.27
Changelog:
<https://bazaar.launchpad.net/~mailman-coders/mailman/2.1/view/head:/NEWS#L8>

Release announcement:
<https://www.mail-archive.com/mailman-users@python.org/msg70962.html>

Reported by:	portscout@ (release)
MFH:		2018Q2
Security:	739948e3-78bf-11e8-b23c-080027ac955c
Security:	CVE-2018-0618
Security:	JVN#00846677
Security:	JPCERT#97432283
2018-06-25 21:58:41 +00:00
Matthias Andree
3dff4583e6 Attempt to support pkg upgrade through scripts WRT last_mailman_version. 2018-02-19 21:23:01 +00:00
Matthias Andree
424c099100 Overhaul default hosts configuration.
- When no virtualhosts are defined, and the default localhost/localhost is
  effective, the post-install script now adds DEFAULT_EMAIL_HOST,
  DEFAULT_URL_HOST, and add_virtualhost() lines to mm_cfg.py.

  Add corresponding support to remove unchanged configurations to the
  deinstall script.

- While here, overhaul crontab configuration to only request a merge if the
  crontab had been modified, and unify progress reports.

- Merge pkg-deinstall into pkg-install, to avoid duplication of code
  that might be missed in later maintenance.

PR:		225961
Reported by:	Terry Kennedy
2018-02-17 12:45:18 +00:00
Matthias Andree
cacb075659 Remove dead link from pkg-message.
PR:		225925
Submitted by:	Yasuhito FUTATSUKI
2018-02-16 23:20:01 +00:00
Matthias Andree
38d3ee3253 mail/mailman: add reopen to rc script's extracommands.
...and pass it through to mailmanctl.
The previous commit only enabled reopen through ..mailman/scripts/mailman.
2018-02-11 23:20:58 +00:00
Matthias Andree
48ca56ce3d Support the upstream "reopen" mode (broken from the beginning in ports)
When the upstream initscript grew a "reopen" mode with 2.1.17 in late 2013,
our patch stuffed the usage information into the wrong place, so that we
inadvertently disabled the new reopen mode, thus never supported it
through the init script in FreeBSD.

Bump PORTREVISION.

PR:		225800
Submitted by:	Yasuhito FUTATSUKI
MFH:		2018Q1
2018-02-11 22:36:07 +00:00
Matthias Andree
e60b89a6a0 Security update to 2.1.26 (XSS bug), assorted other fixes.
- Fix checksum failures in Defaults.py[c]:
  No longer patch Defaults.py in postinstall, instead configure
  --with-mailhost=localhost --with-urlhost=localhost, as
  Fedora and Arch Linux do.

- Add a related note to FreeBSD-post-install-notes.

- Add a related safeguard to the rcfile, which will refuse to run
  if the DEFAULT_*_HOSTs are not configured. This can be changed
  with a new mailman_run_localhost="YES" rc.conf setting, which will
  then restrict itself to printing the warnings, but still start mailman.

- Update htdig patch to upstream SVN r1734.

- Bump USES, python:2 -> python:2.7

- Regenerated patches.

Changelog:
https://bazaar.launchpad.net/~mailman-coders/mailman/2.1/view/1743/NEWS#L8

Release/SecuritY announcement:
https://www.mail-archive.com/mailman-users@python.org/msg70478.html

PR:		225767 (related vuxml entry)
Reported by:	Vladimir Krstulja
MFH:		2018Q1
Security:	CVE-2018-5950
Security:	3d0eeef8-0cf9-11e8-99b0-d017c2987f9a
2018-02-08 22:32:23 +00:00
Matthias Andree
c9befd3621 Add a newsyslog configuration file, to rotate logs.
This enforces the EXAMPLES option because we can't keep
the .sample file in etc/newsyslog.conf.d/* - it would be processed
as the actual file, so we use %%EXAMPLESDIR%% for the distributed version.
2017-09-16 14:22:43 +00:00
Matthias Andree
4412b82121 Fix up DEFAULT_URL_HOST/DEFAULT_MAIL_HOST for jailed or external builds.
If the package is built in, for instance, poudriere, or on a computer other
than the one it is later installed on, the DEFAULT_MAIL_HOST and
DEFAULT_URL_HOST variables in the Mailman/Defaults.py file were unsuitable.

Leverage pkg-install to fix these up to be the same as hostname -f at
install time.

[The MFH would require the intermediate update to 2.1.24 to be included.]

MFH:		2017Q3
2017-09-10 16:53:56 +00:00
Matthias Andree
e1afedae1c Update to new upstream release 2.1.22.
Changelog: http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/view/1643/NEWS#L8
2016-04-22 23:14:18 +00:00
Matthias Andree
d2a065da18 Avoid patch-LP1551075 when HTDIG is enabled. [1]
This patch is part of the HTDIG integration patch already. [1]

Also correct namazurc file path in pkg-message, bumping PORTREVISION.

PR:		207876 [1]
Submitted by:	David Siebörger [1]
2016-03-10 19:50:12 +00:00
Matthias Andree
240fff7e0b Preserve some kinds of signatures, reenable HTDIG option.
Pull upstream change 1629 to fix Launchpad Bug #1551075
<https://bugs.launchpad.net/mailman/+bug/1551075>. This fix improves
preservation of OpenPGP MIME multipart signatures, by not collapsing
a multipart with a single sub-part inside multipart/signed parts.
See the Launchpad bug report for details.

EXPERIMENTAL feature: Reenable HTDIG support by rolling the patch on our
own, and laying down instructions to do so in the Makefile.  Mark Sapiro
no longer maintains the patch.

Bump PORTREVISION to 3.

Note that the upstream maintainer considers another release in a few
weeks' time, and called for help with updating translations.  If you
want to help, see
<http://www.mail-archive.com/mailman-users%40python.org/msg68036.html>
2016-03-02 08:34:40 +00:00
Matthias Andree
60308f52f6 Make sure pkg-install works with postfix-base, too.
Prior to this fix, pkg-install used hardcoded
${PKG_PREFIX}/sbin/postconf, but postfix-base installs it into
/usr/sbin/postconf.

Instead, do a path search for postconf in ${PKG_PREFIX}/sbin:$PATH and
cache the result in a variable.
2016-03-02 00:12:11 +00:00
Matthias Andree
97297c27ea Fix pkg-install "install -d" invocation.
It used to use GNU-install-isms (options after arguments) that don't
work with BSD install and caused two spurious directories to be created,
one named -g, the other usually named "mailman" (or whichever group name
was configured).  Bumps PORTREVISION.

PR:		207528 (Attachment #167455)
Submitted by:	ohauer@
2016-03-01 00:05:08 +00:00
Matthias Andree
4d4e2f35e8 Fix a leftover in rcfile, make more robust.
Make things more robust such that options in mailman_flags don't kill
the start.
2015-12-30 15:00:35 +00:00
Matthias Andree
3c21594264 Fix stop method in rc.d script to wait for process to exit.
To that end, simplify and use rc.subr default methods where possible.
2015-12-30 14:21:33 +00:00
Mathieu Arnold
6172d4b590 Remove $FreeBSD$ from patches files everywhere.
With hat:	portmgr
Sponsored by:	Absolight
2015-05-22 20:34:27 +00:00
Matthias Andree
3eb0692848 Update to new upstream release 2.1.20.
Fixes one security bug [1], a few other bugs, and adds a feature so that
list admins can edit list addresses.

Uses newer Mailman-and-HTDig integration patches. [2]

Security:	CVE-2015-2775 [1]
Security:	a5f160fa-deee-11e4-99f8-080027ef73ec [1]
PR:		199286 [2]
Submitted by:	David Siebörger [2]
2015-04-09 20:08:50 +00:00
Matthias Andree
b23d38e29f Update to new upstream release 2.1.19.
Changes: https://mail.python.org/pipermail/mailman-announce/2015-March/000205.html
2015-03-02 07:26:30 +00:00
Matthias Andree
569aa08fee Install powerlogo.png in both image locations.
(Reported by Alex Stangl.)

Take the opportunity to convert powerlogo from GIF to PNG.

Check permissions of mailman/qfiles directory and top-level
subdirectories from post-install before running check_perms script,
further to the existing workarounds for pkg/libarchive permissions
issues.
2015-01-17 13:29:24 +00:00
Matthias Andree
837c36bed9 Update Apache instructions in post-install notes for 2.4 [1], dropping 1.3.
Revise language a bit.
Spell qmail with lowercase q.

Submitted by:	[1] Tom Eagle
2015-01-08 22:53:32 +00:00
Matthias Andree
b37db99ba9 With CVS gone, use the GIF file directly, ditching the uuencoding. 2015-01-07 00:25:46 +00:00
Matthias Andree
1661e02b60 Update rcfile and permission handling.
- Move directory permission handling into pkg-install, to work around
  pkg/libarchive issues on 9.3.
- Handle some crucial directory permissions directly in pkg-install,
  so that running check_perms becomes optional.
- Try a bit harder to preserve permissions on the archives/private dir.
- The rcfile now fixes directory permissions by default on start.
- You can now set mailman_fix_perms="NO" in the /etc/rc.conf* files,
  to avoid running check_perms -f on start, or from pkg-install.
- Clean up pkg-plist.
- Bump PORTREVISION to 6.

Suggested by:	bapt@, peter@
2015-01-07 00:12:45 +00:00
Matthias Andree
fa3fa04f49 The rcfile now runs bin/check_perms so users have a visual clue in case
they installed the package without running scripts (pkg install -I).
Clean up inconsistent image (=icon) installation. Reported by Alex Stangl.
Makefile: Shuffle things around to please portlint.
Makefile: Clean up muting: only mute RM, comments, MKDIR.
Makefile: Move postfix checks into pkg-install.
pkg-deinstall: drop workaround for traditional pkg_delete.
pkg-deinstall: less verbose mail list reporting.
pkg-deinstall: cleanups for last_mailman_version handling.
pkg-install: defeat "Re-run..." line from check_perms to avoid confusing users.
pkg-plist: cleanups and modernization. Sets directory permissions.
  NOTE: pkg 1.4.1 is unable to extract these on package installs,
  "make install" however should be fine.
2014-12-27 01:19:30 +00:00
Matthias Andree
313bbece6a Add OPENSMTPD's user ID [1]. Add warnings about GIDs [2].
The FreeBSD pkg-message and post-install documentation now clearly warn
that the binary package is only meant for use with Sendmail, and
hints that poudriere can be used to build a Mailman package with
different options.

PR:		192230 [1]
Submitted by:	feld [1], Tom Limoncelli [2]
2014-08-13 20:05:15 +00:00
Adam Weinberger
08a006d08a Rename all patches that contain '::' as a path separator, and use
'__' instead.
2014-07-29 17:12:47 +00:00
Matthias Andree
608099abc5 Avoid leftovers on pkg_add-based systems by running a
depth-first remove of empty directories under the Mailman directory.

Submitted by:	jenkins/swills@
2014-05-16 15:56:24 +00:00
Matthias Andree
57bfaa32c3 - Update to new upstream release 2.1.17, resetting PORTREVISION.
- Remove patch-Makefile.in, which has been integrated by upstream.

- Announcement:
<https://mail.python.org/pipermail/mailman-announce/2013-November/000186.html>

- Poudriere 3.0.13 ticket filed about misreported orphans in testport:
<https://fossil.etoilebsd.net/poudriere/tktview/e8d957a27f8ce8b6255ed655d031e6d05b02492c>
2013-11-25 07:56:14 +00:00
Matthias Andree
b5ca2a054c simplify, per Mark Sapiro's suggestion 2013-10-23 21:00:45 +00:00
Matthias Andree
86b3563dc7 Distill Python-compileall fix into something fit for shipping upstream,
and fixing a missed directory component along the way (bumping PORTREVISION).
2013-10-18 18:34:09 +00:00
Matthias Andree
9ea5412619 Upgrade to new upstream release 2.1.16, release notes:
https://launchpad.net/mailman/2.1/2.1.16/

Support stage directory. (Requires Python 2.7, 2.6 is no longer
sufficient.) This requires us to compile the Python scripts ourselves to
avoid spilling the stagedir name all over the .pyc files, as Mailman's
build would do (causing complaints from make stage-qa).
While there, compile bin/*.py programs, too.

The post-install section of the Makefile is more verbose now.

Run Mailman's bin/update after install.

Fixes to handling the mailman_last_version file to avoid leftover dirs
from an unused Mailman installation and deinstallation.

Scripts are more robust now, and use mktemp -d for temporary directories.
2013-10-18 16:42:11 +00:00
Matthias Andree
854b45ea77 Note that I could not fully test all integrations yet. If integrations are
failing, please add detailed information how you set up your MTA, and
Mailman, what user/group IDs are, how list aliases are managed, and
thereabouts.

- Update to 2.1.15. [2] Changes: click View the full Changelog on
  https://launchpad.net/mailman/2.1/2.1.15
- Fix without-NLS install: Install at least English template. [1]
- Drop EXIM3 option, we don't have an Exim 3 port any more.
- Drop INTEGRATION option, which would at best be confusing.
- Reformat COMMENT to fit into common limits.
- Fix typo in COURIER_DESC.
- When Postfix integration is chosen, add BUILD and RUN_DEPENDS on
  Postfix because we need the postconf program.
- Use htdig patches for Mailman version 2.1.12 and remove BROKEN tag,
  in an experimental attempt to revive htdig support.
- Fix a few minor glitches in FreeBSD-post-install-notes.
- Drop files/patch-Mailman__Cgi__confirm.py, integrated in upstream tarball.
- Add launchpad.net to MASTER_SITES.
- Update files/postfix-verp.diff.
- Install a dummy one-line text file into PYTHON_SITELIBDIR so that
  Python's upgrade-site-packages would reinstall Mailman. [1]
- Add "status" support for rc.d script. [3]
- Change pre-fetch: to pre-everything::
- Revise formatting of pre-everything text to make clear it displays
  default values, not current values. To avoid ports/170280.

PR:		ports/135503 [1]
PR:		ports/170280 [2]
PR:		ports/170285 [2]
PR:		ports/176180 [1]
PR:		ports/181298 [3]
Submitted by:	Lowell Gilbert [1]
Submitted by:	Stefan Lasiewski [2]
Submitted by:	Oliver Fromme [3]
2013-08-29 22:58:07 +00:00
TAKATSU Tomonari
ac239c2b83 - mail/mailman [1]
* Add LICENSE section
  * Add CONFLICTS with japanese/mailman
  * Make use of SUB_FILES
  * Make use of PORTDOCS
  * Apply simple use of OPTIONS
  * Add WITHOUT_NLS knob to make portlint happier
  * Append "MTA = 'Postfix'" to mm_cfg.py.dist.in when defined
    both WITH_POSTFIX and WITH_INTEGRATION at the same time [3]
  * Bump PORTREVISION

- japanese/mailman [2]
  * Switch to Japanized mailman 2.1.14+j7 based on mail/mailman
  * Take maintainership
  * Add CONFLICTS with mail/mailman
  * Update pkg-descr
  * Set PORTEPOCH because 2.1.14.j7 is less than 2.1.14_6

PR:		ports/165404 (based on) [1], ports/165403 [2]
Submitted by:	tota (myself) [1] [2]
Suggested by:	Yoshito Takeuchi [3]
Approved by:	Sunagawa Koji (maintainer) [2]
Dedicated to:	Tokio Kikuchi
2012-03-04 06:00:38 +00:00
Doug Barton
83eb2c3700 In the rc.d scripts, change assignments to rcvar to use the
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().

In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.
2012-01-14 08:57:23 +00:00
Chris Rees
2b3a95fed8 Let's try this one again.
- Stop touching files outside WRKDIR before install
- Use USERS and GROUPS -- this time via patch [1]
- Change BROKEN to IGNORE fo incorrect OPTIONS choices
- Use @stopdaemon

PR:		ports/157868
Submitted by:	Guido Falsi <mad@madpilot.net>
Approved by:	rene (mentor)
2011-06-21 16:00:53 +00:00
Wesley Shields
c70c2dcaca - Fix missing escapes in the rc script.
PR:		ports/157868
Submitted by:	Roland Behme <rb@nugman.de>
2011-06-14 11:49:25 +00:00