Several ports had rc.d scripts with hardcoded command_interpreter string
as /usr/bin/perl. This symlink is not guaranteed to be in place, and it
isn't even an option for perl 5.20. For affected ports, the interpreter
was changed to localbase.
In one case, the interpreter was correct, but it wasn't surround by
quotes. Since the rc.d script would break if a space was contained in
${PREFIX}, quotes were added in that case.
command=foo >/dev/null 2>&1
|
v
command=foo
command_args='>/dev/null 2>&1'
This is clearly what should have been done, for several reasons.
No PORTREVISION bump because the old version simply ignored everything
after the space, and does not seem to have done any harm. However
it's good to clean these up so that similar errors aren't pasted into
a new script where they might actually matter.
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().
In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.
handled after load_rc_config per Handbook. For example, if user sets
name_pidfile in rc.conf, it does not correctly pass to name_flags because
when we set name_flags, it uses our default name_pidfile, but not user's.
- Bump PORTREVISION as rc scripts changed.
Approved by: portmgr (pav), Xavier Beaudouin <kiwi at oav.net> (ovs maintainer)
