sync/ports
1
0
Fork 0
mirror of https://git.freebsd.org/ports.git synced 2025-06-23 21:50:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
482599 commits 47 branches 104 tags 1.8 GiB
Commit graph

8 commits

Author SHA1 Message Date
Mathieu Arnold
ed29b995f5 Remove confusing and obsolete comment, 10.2 support was axed in 
ports r430441.
 2018-01-18 15:42:15 +00:00
Antoine Brodin
0e8ef7f48c Skip comments when parsing GID_FILES 
Reviewed by:	bapt
MFH:		2017Q4
Differential Revision:	https://reviews.freebsd.org/D12682
 2017-10-16 08:30:27 +00:00
Mathieu Arnold
5fb8017b6b Fix using more than one files in UID_FILES and GID_FILES. 
Repeat after me: If you change IFS, it will break something unexpected.

The problem is that we use IFS to change read's field separator.  This
has the side effect of changing how sh(1) splits all string, including
in command parsing functions.

In this case, unless quoted, the strings are always splitted using IFS.
So changing IFS will change how these strings are splitted, and you end
up having a headache.  For example:

    $ GID_FILES="foo bar"
    $ set -x
    $ echo $GID_FILES
    + echo foo bar
    foo bar

    $ IFS=:
    $ GID_FILES="foo bar"
    $ set -x
    $ echo $GID_FILES
    + echo 'foo bar'
    foo bar

In the first case, it runs echo with two arguments, first is foo, second is bar.
In the second case, it runs echo with one argument, 'foo bar'.

To fix this, restrict the time during which IFS changes to only one
command, set, and use positional parameters to extract values.

Reported by:	feld
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D11632
 2017-07-19 11:55:46 +00:00
Rene Ladan
6f019c90b3 Remove support for FreeBSD < 10.3 from Mk/* 
This does not yet convert the files to bmake.

Reviewed by:	mat
Differential Revision:	https://reviews.freebsd.org/D9016
 2017-01-03 07:24:49 +00:00
Antoine Brodin
428645d185 Fix directory creation when primary group is different from user name 2016-11-01 00:33:36 +00:00
Bryan Drewery
e73c0c591a Fix package upgrade setting wrong ownership on a package's $HOME. 
This happens when the UID/GID doesn't match the expected number from
UIDs/GIDs.

https://github.com/freebsd/pkg/issues/1485 has more details.

With hat:	portmgr
Discussed with:	bapt, mat
 2016-10-31 22:37:21 +00:00
Mathieu Arnold
f69e8567aa Ease debugging of Mk/Scripts scripts. 
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6474
 2016-05-20 19:01:59 +00:00
Mathieu Arnold
b1fb5a15c1 Extract the users/groups creation into a separate shell script. 
This adds a few features:
- it checks that the UID line has the right number of fields [1]
- it tells the user that there are groups that he may want to remove [2]

PR:		208800, 173318 [1], 157546 [2]
Submitted by:	mat
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D5939
 2016-04-18 18:39:44 +00:00