Commit graph

10 commits

Author SHA1 Message Date
Antoine Brodin
32617460e5 Use full path to file(1) from base as sysutils/file is buggy
PR:		231554
2018-10-06 08:19:19 +00:00
Mathieu Arnold
258800dd7b SC2046: Quote this to prevent word splitting.
When command expansions are unquoted, word splitting and globbing will
occur. This often manifests itself by breaking when filenames contain
spaces.

Trying to fix it by adding quotes or escapes to the data will not work.
Instead, quote the command substitution itself.

If the command substitution outputs multiple pieces of data, use a loop
instead.

Add an exception when using set -- where splitting is intended.

PR:             227109
Submitted by:   mat
Exp-run by:	antoine
Sponsored by:   Absolight
2018-06-08 09:26:20 +00:00
Mathieu Arnold
bf064c8390 SC2006: Use $(..) instead of legacy ...
Backtick command substitution `STATEMENT` is legacy syntax with several
issues.

 - It has a series of undefined behaviors related to quoting in POSIX.
 - It imposes a custom escaping mode with surprising results.
 - It's exceptionally hard to nest.

$(STATEMENT) command substitution has none of these problems, and is
therefore strongly encouraged.

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
2018-06-01 16:20:54 +00:00
Mathieu Arnold
f69e8567aa Ease debugging of Mk/Scripts scripts.
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D6474
2016-05-20 19:01:59 +00:00
Olli Hauer
3ad4a7aca8 - add additional blank line, else the first line of the error message
is directly appended to the last line from the build output

deamon@ already fixed the typos in the error message (r404229)

PR:		203157
2015-12-23 11:49:08 +00:00
Dmitry Sivachenko
efa42a5fc4 Fix typo in message. 2015-12-22 12:56:28 +00:00
Ryan Steinmetz
041a8dd21d - Provide a check/warning/fix for users that upgraded from an older release and missed UPDATING 20150213
Approved by:	portmgr (bapt)
2015-07-07 06:03:35 +00:00
Antoine Brodin
a417c432e5 - Remove dead function from find-lib.sh
- Print a message if dependency registration on a package failed

With hat:	portmgr
2015-04-10 08:45:09 +00:00
Baptiste Daroussin
a77d7def34 Stop trying to resolv symlinks when looking up for a shlib
file -L is resolving them properly and actual-package-depends.sh is also
correctly resolving them

Exp-run by:	antoine
2015-04-09 06:36:01 +00:00
Baptiste Daroussin
90dc66b285 Rework dependency registration
Change the way the dependencies are registred so that now it follows the same
mechanism as when the *_DEPENDS making the dependency registration system ready
to allow multiple packages from the same origin such as flavours and subpackages

Also allowing to install twice the same port one built with python33 and the
other built with python27 for example.

PR:		19702
With help of:	antoine
Exp-run:	portmgr (antoine)
2015-02-09 17:16:43 +00:00