Commit graph

15 commits

Author SHA1 Message Date
Gleb Popov
2c24a73ff2 Features/debuginfo.mk: Automatically generate a subpackage with debugging info.
Differential Revision: https://reviews.freebsd.org/D43515

Tested by:	flo
Approved by:	portmgr, emaste
2024-02-03 09:31:13 +03:00
Mathieu Arnold
5d33e04596
framework: Remove $FreeBSD$
Where appropriate fiddle with a few other things.
2021-04-06 16:27:10 +02:00
Mathieu Arnold
f916081e1c Add set pipefail in most framework scripts.
set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.

PR:		250723
Exp-run by:	antoine
Reviewed by:	bapt
Approved by:	bapt
Differential Revision:	https://reviews.freebsd.org/D27007
2020-11-11 13:29:52 +00:00
Mathieu Arnold
aeda355b1b Backout r554139. 2020-11-05 16:51:30 +00:00
Mathieu Arnold
e9b2078c6c Add set pipefail in most framework scripts.
set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.
2020-11-05 16:42:35 +00:00
Bryan Drewery
19aa5ff42e generate-symbols: Need @dir entries if PREFIX!=LOCALBASE.
- makeplist/check-plist: Don't suggest or complain about @dir entries
  for debug symbols added by this script. Same as is done for the
  debug symbols themselves.

Sponsored by:	DellEMC
2019-11-07 20:49:17 +00:00
Bryan Drewery
51409ae5ed Don't try splitting symbols out of .a archives.
Sponsored by:	DellEMC
2019-07-13 17:32:14 +00:00
Bryan Drewery
d64353f33f Fix handling of ports with *1* file.
Reported by:	glebius
Sponsored by:	DellEMC
2019-07-10 16:18:32 +00:00
Bryan Drewery
9ba153d1d4 generate-symbols: Commit a working version.
This file originated from Isilon's codebase. When I upstreamed it
originally I refactored it to a broken version. This is now the
working version.

Debug files are purposely moved to LOCALBASE/lib/debug regardless
of what PREFIX is.

Sponsored by:	DellEMC
2019-06-26 01:19:00 +00:00
Bryan Drewery
6e992e91cb Revert r505129: I still have the wrong version. 2019-06-26 01:07:41 +00:00
Bryan Drewery
9ec378268c Allow generate-symbols.sh to actually work.
It splits out symbols to PREFIX as well not LOCALBASE. Fix
check-stagedir.sh for that.
2019-06-26 00:44:55 +00:00
Bryan Drewery
6ced1c7607 Speedup ELF file detection almost 100%.
This uses the same pattern we have in qa.sh.  Rather than using file(1),
which reads the whole file and does too much magic, use readelf(1) which
bails out if the file lacks the proper ELF headers.

(This file is not yet used by anything)

Sponsored by:	DellEMC
2019-06-11 22:56:32 +00:00
Mathieu Arnold
b234bfd716 SC2162: read without -r will mangle backslashes.
By default, read will interpret backslashes before spaces and line
feeds, and otherwise strip them. This is rarely expected or desired.

Normally you just want to read data, which is what read -r does. You
should always use -r unless you have a good reason not to.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
2018-06-08 09:26:34 +00:00
Mathieu Arnold
d605296d6e SC2145: Argument mixes string and array. Use * or separate argument.
The behavior when concatenating a string and array is rarely intended.
The preceeding string is prefixed to the first array element, while the
succeeding string is appended to the last one. The middle array elements
are unaffected.

For example, with the parameters foo,bar,baz, "--flag=$@" is equivalent
to the three arguments "--flag=foo" "bar" "baz".

PR:		227109
Submitted by:	mat
Sponsored by:	Absolight
2018-06-01 16:20:22 +00:00
Bryan Drewery
34da0bbb9e Add some work-in-progress scripts for splitting symbols out into PREFIX/lib/debug.
This is only missing the bsd.port.mk pieces to hook it up fully.  A blocker
for hooking that up has been sub-packages, even though some implementation
could be made without them.  For now just commit what I have so it is not
forgotten.

Obtained from:	OneFS
Sponsored by:	EMC / Isilon Storage Division
With hat:	portmgr
2015-10-19 17:04:33 +00:00