Generally disable warnings-as-errors for all openjdk ports, removing all
the conditionals we have now for particular architectures and/or
compilers. It does not make sense to have this on by default, unless you
are an upstream maintainer.
PR: 281188
Approved by: maintainer timeout (2 weeks)
MFH: 2024Q3
pass CFLAGS, CXXFLAGS and LDFLAGS to the build
This enables more easily testing different build options.
fix build on gcc by passing --disable-precompiled-headers not only on powerpc64
"Without this, I was getting PCH-error from g++12 on my amd64 machine too."
PR: 279367
Tested by: poudriere
Approved by: maintainer timeout (java@)
Clang 19 is now more strict about undefined integral expressions used as
constants in enum, which results in errors compiling java/openjdk11,
similar to:
/wrkdirs/usr/ports/java/openjdk11/work/jdk11u-jdk-11.0.24-8-1/src/jdk.pack/share/native/common-unpack/constants.h:206:33: error: expression is not an integral constant expression
206 | AO_UNUSED_MBZ = (-1)<<13, // options bits reserved for future use.
| ^~~~~~~~
/wrkdirs/usr/ports/java/openjdk11/work/jdk11u-jdk-11.0.24-8-1/src/jdk.pack/share/native/common-unpack/constants.h:206:37: note: left shift of negative value -1
206 | AO_UNUSED_MBZ = (-1)<<13, // options bits reserved for future use.
| ^
Replace the negative value with ~0u to fix this error.
PR: 280560
Approved by: glewis (maintainer)
MFH: 2024Q3
Segfaults are no longer observed with current versions of LLVM 17 and 18
in base 13.3 and 14.1, so there is no need to pull such an old version
from ports to build.
For example build java/openjdk11 with LLVM from base and then build
java/eclipse and java/openjfx14 using java/openjdk11: build and run
without errors.
PR: 280056 260319
Approved by: java (maintainer, timeout 14 days)
Thanks again to jbeich for noticing various things I overlooked.
Reviewed by: acm, ashish, eduardo, ehaupt, eugen, jbeich, martymac, mat, nobukata, sunpoet, tagattie, yuri, arrowd, kde
Differential Revision: https://reviews.freebsd.org/D45141
Similar to certificate management with certctl(8) users can use custom
enterprise CAs. These need to be assembled into a custom cacerts file.
Therefore, an admin can install a custom truststore to an arbitrary
location and have the OpenJDK port symlink to it by adding
OPENJDK_SYMLINK_CACERTS to make.conf.
E.g., OPENJDK_SYMLINK_CACERTS=/usr/local/etc/ssl/cacerts.
PR: 229329
Approved by: jrm (mentor), otis (mentor), glewis
Differential Revision: https://reviews.freebsd.org/D42720
UniFi controller is headless Java application that requires
OpenJDK that depends on full CUPS port. In fact, the latter originally
required cups-client port only that was later removed and merged
to full cups port, so openjdk11 now requires full CUPS.
However, OpenJDK really needs only some header files out of CUPS distribution
and officially supports building --with-cups-include instead of --with-cups.
This change introduces new CUPS port option to java/openjdk11
that defaults to ON to preserve current behaviour.
With CUPS option turned OFF it skips build dependency on full cups:
instead, it downloads and extracts its distfile and
builds --with-cups-include pointing to extracted cups distfile.
Default build not affected, so PORTREVISION not changed.
PR: 264792
Approved by: java (maintainer timeout, over 7 months)
Commit b7f05445c0 has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.
This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.
Approved by: portmgr (tcberner)
It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.
Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.
There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.
This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.
There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.
The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.
Approved by: portmgr (tcberner)
Recent LLVM versions issue warnings for "|" being used with boolean
operands. Such operations exist in OpenJDK and the source lines are
marked with comments to not use logical operations instead.
This breaks the build on 13.1 and -CURRENT when building with LLVM-13
or newer due to the -Werror option being passed to the compiler.
Fix this issue by casting one of the boolean operands to int, as
suggested by the compiler in the error message for the case that the
"|" operation should actually be used on purpose.
I had submitted this patch as an attachment to PR 265687 on
2022-08-07, but it has been ignored by the maintainer (java team).
PR: 265687
Approved by: portmgr (implicit)
Go back to using LLVM 12, bin/java built with LLVM 13 crashes with:
* For target jdk__packages_attribute.done:
A fatal error has been detected by the Java Runtime Environment:
SIGILL (0x4) at pc=0x0000000802e3d438, pid=28756, tid=149399
JRE version: (11.0.16+8) (build )
Java VM: OpenJDK 64-Bit Server VM (11.0.16+8-1, mixed mode, tiered, compressed oops, serial gc, bsd-ppc64)
Problematic frame:
V [libjvm.so+0xe3d438] JVM_RaiseSignal+0x446bcc
Revert part of commit 3d803e4460 that should only have affected the
deskutils/calendar port.
This patch that has been committed by accident had already been
attached to PR 265687 to fix the build issue of openjdk11 on -CURRENT,
but it is up to the java@ team to apply this or some other fix.
Approved by: portmgr (implicit)
Update the man page to match the version the -CURRENT base system.
The only change is a better description of the // single line comment
syntax, i.e. that // is only considered to start a comment when it
appears at the start of the line or after white space. This allows to
embed URLs in calendar entries.
This restores the previous LLVM/Clang 13 workaround. I had thought
the upstream changes would address this, but still seeing reports of
crashes when compiled with LLVM/Clang 13.
PR: 260319
Reported by: various
During an exp-run for llvm 13 (see bug 258209), it turned out that
java/openjdk11 through openjdk13 fail to build with clang 13:
=== Output from failing command(s) repeated here ===
* For target jdk__packages_attribute.done:
These crashes are all caused by the markOop/markOopDesc classes, which
are used to keep track of objects, and which are 'marked' using the low
few bits. (See
https://github.com/openjdk/jdk13u/blob/master/src/hotspot/share/oops/markOop.hpp
).
After some laborious bisecting, I found out that these crashes start
occuring after the upstream commit https://github.com
/llvm/llvm-project/commit/16d03818412 (Return "[CGCall] Annotate this
argument with alignment").
What happens afterwards, is that clang considers the "this" pointer to
always be aligned to the alignment of the actual object, and then
masking or adding a few low bits is not working as expected.
The reason openjdk14 and higher work fine with clang 13, and don't crash
similarly, is that the OpenJDK people completely redid the
markOop/markOopDesc classes in
ae5615c614
("8229258: Rework markOop and markOopDesc into a simpler mark word value
carrier"). E.g, the markOopDesc class was renamed to markWord, and
*stores* a pointer-like value instead of *being* a pointer-like value.
This is a much safer way of handling things.
However, this upstream commit is *very* large, as are a few of its
follow-ups, which is probably the reason why it has not been backported
to JDKs <= 13. I tried manually backporting it, but got lost in many
nasty patch conflicts and problems.
As a workaround, build openjdk8 through 13 with clang12 from the
devel/llvm12 port, for the time being.
In addition, allow openjdk14 through 17 to be built with clang 13, by
adding -Wno-unused-but-set-parameter to the compilation flags.
PR: 258954
Approved by: maintainer timeout (2 weeks)
MFH: 2021Q4
During an exp-run for llvm 12 (see bug 255570), it turned out that
java/openjdk11 and java/openjdk11-jre do not build with clang 12.0.0:
Creating interim jimage
Compiling 2 files for BUILD_DEMO_Notepad
This is due to a missing backport of an upstream commit:
commit c484d8904285652246c3af212a4211b9a8955149
Author: Thomas Stuefe <stuefe@openjdk.org>
Date: Tue Mar 16 05:49:01 2021 +0000
8263557: Possible NULL dereference in Arena::destruct_contents()
Reviewed-by: kbarrett, coleenp
Approved by: maintainer timeout (2 weeks)
PR: 255900
MFH: 2021Q2
