Fix crash when editing or adding new transactions

PR:		228752
Submitted by:	Peter <fbsdq@peterk.org>
Obtained from:	https://bugs.kde.org/show_bug.cgi?id=392735
This commit is contained in:
Jason E. Hale 2018-06-05 21:51:55 +00:00
parent e5e551900e
commit ea8580cb18
Notes: svn2git 2021-03-31 03:12:20 +00:00
svn path=/head/; revision=471825
3 changed files with 20 additions and 13 deletions

View file

@ -2,6 +2,7 @@
PORTNAME= kmymoney
PORTVERSION= 5.0.1
PORTREVISION= 1
CATEGORIES= finance kde
MASTER_SITES= KDE/stable/${PORTNAME}/${PORTVERSION}/src

View file

@ -1,13 +0,0 @@
Fix crash when adding a new schedule to scheduled transactions
--- kmymoney/dialogs/transactioneditor.cpp.orig 2018-04-17 02:57:53 UTC
+++ kmymoney/dialogs/transactioneditor.cpp
@@ -178,7 +178,7 @@ void TransactionEditor::setup(QWidgetList& tabOrderWid
// remove all unused widgets and don't forget to remove them
// from the tab order list as well
- d->m_editWidgets.removeOrphans();
+ // d->m_editWidgets.removeOrphans();
QWidgetList::iterator it_w;
const QWidgetList editWidgets(d->m_editWidgets.values());
for (it_w = tabOrderWidgets.begin(); it_w != tabOrderWidgets.end();) {

View file

@ -0,0 +1,19 @@
Fix crash when editing transactions
https://bugs.kde.org/show_bug.cgi?id=392735
--- kmymoney/widgets/qwidgetcontainer.cpp.orig 2018-03-18 15:55:30 UTC
+++ kmymoney/widgets/qwidgetcontainer.cpp
@@ -51,9 +51,10 @@ void QWidgetContainer::removeOrphans()
if ((*it_w) && (*it_w)->parent())
++it_w;
else {
- delete(*it_w);
- remove(it_w.key());
- it_w = begin();
+ QWidget* const w = *it_w;
+ it_w = erase(it_w);
+ if (w)
+ w->deleteLater();
}
}
}