From e2e2d02ab3092ebad528afab206e7e47335fa4e9 Mon Sep 17 00:00:00 2001 From: Edwin Groothuis Date: Wed, 8 Oct 2003 03:44:49 +0000 Subject: [PATCH] Port update: www/elinks Elinks crashes on frameset webpages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I noticed elinks crashes most of the times after parsing a web page which includes framesets (try loading a frameset with for example rows="200,*"). This occurs because it tries to free some arbitrary block of memory without checking if the previous functions returned errors. PR: ports/56668 Submitted by: Mário Freitas Approved by: Jason Harris --- www/elinks/Makefile | 2 +- .../files/patch-src::document::html::parser.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 www/elinks/files/patch-src::document::html::parser.c diff --git a/www/elinks/Makefile b/www/elinks/Makefile index b73d69a2fb24..988be553f813 100644 --- a/www/elinks/Makefile +++ b/www/elinks/Makefile @@ -7,7 +7,7 @@ PORTNAME= elinks PORTVERSION= 0.4.2 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= www MASTER_SITES= http://elinks.or.cz/download/ DISTFILES= ${DISTNAME}${EXTRACT_SUFX} ${DISTNAME}${EXTRACT_SUFX}.asc diff --git a/www/elinks/files/patch-src::document::html::parser.c b/www/elinks/files/patch-src::document::html::parser.c new file mode 100644 index 000000000000..c90bd55328ba --- /dev/null +++ b/www/elinks/files/patch-src::document::html::parser.c @@ -0,0 +1,13 @@ +--- src/document/html/parser.c.orig Sat Sep 6 02:09:37 2003 ++++ src/document/html/parser.c Sat Sep 6 02:10:14 2003 +@@ -2330,8 +2330,8 @@ + parse_frame_widths(d, y, HTML_FRAME_CHAR_HEIGHT, &fp.yw, &fp.y); + fp.parent = html_top.frameset; + if (fp.x && fp.y) html_top.frameset = special_f(ff, SP_FRAMESET, &fp); +- mem_free(fp.xw); +- mem_free(fp.yw); ++ if (fp.x) mem_free(fp.xw); ++ if (fp.y) mem_free(fp.yw); + + free_cd: + mem_free(c);