converters/lua*-iconv: enable -fPIC on arm64 and i386, for lld

Shared objects should be built as PIC, and lld enforces this by default.
Add aarch64 and i386 cases to the existing set of per-arch CFLAGS, and
remove the BROKEN_aarch64.

Approved by:	portmgr (lld blanket)
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Ed Maste 2018-09-18 19:53:46 +00:00
parent 176251159f
commit c460a0dbeb
Notes: svn2git 2021-03-31 03:12:20 +00:00
svn path=/head/; revision=480070
2 changed files with 6 additions and 6 deletions

View file

@ -3,7 +3,7 @@
PORTNAME= iconv PORTNAME= iconv
PORTVERSION= 7 PORTVERSION= 7
PORTREVISION= 2 PORTREVISION= 3
CATEGORIES= converters CATEGORIES= converters
MASTER_SITES= GHC MASTER_SITES= GHC
PKGNAMEPREFIX= ${LUA_PKGNAMEPREFIX} PKGNAMEPREFIX= ${LUA_PKGNAMEPREFIX}
@ -15,8 +15,6 @@ COMMENT= Iconv binding for Lua 5
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/COPYING LICENSE_FILE= ${WRKSRC}/COPYING
BROKEN_aarch64= fails to link: can't create dynamic relocation R_AARCH64_ABS64 against local symbol in readonly segment
USES= pkgconfig iconv lua USES= pkgconfig iconv lua
USE_GITHUB= yes USE_GITHUB= yes
@ -27,7 +25,9 @@ PLIST_FILES= ${LUA_MODLIBDIR}/iconv.so
CFLAGS+= `pkgconf --cflags lua-${LUA_VER}` -I${LOCALBASE}/include CFLAGS+= `pkgconf --cflags lua-${LUA_VER}` -I${LOCALBASE}/include
MAKE_ARGS= LUABIN=${LUA_CMD} CFLAGS="${CFLAGS}" MAKE_ARGS= LUABIN=${LUA_CMD} CFLAGS="${CFLAGS}"
LDFLAGS+= -shared ${ICONV_LIB} -L${LOCALBASE}/lib LDFLAGS+= -shared ${ICONV_LIB} -L${LOCALBASE}/lib
CFLAGS_aarch64= -fPIC
CFLAGS_amd64= -fPIC CFLAGS_amd64= -fPIC
CFLAGS_i386= -fPIC
do-install: do-install:
@${MKDIR} ${STAGEDIR}${LUA_MODLIBDIR} @${MKDIR} ${STAGEDIR}${LUA_MODLIBDIR}

View file

@ -3,7 +3,7 @@
PORTNAME= iconv PORTNAME= iconv
PORTVERSION= 7 PORTVERSION= 7
PORTREVISION= 1 PORTREVISION= 2
CATEGORIES= converters CATEGORIES= converters
MASTER_SITES= GHC MASTER_SITES= GHC
PKGNAMEPREFIX= ${LUA_PKGNAMEPREFIX} PKGNAMEPREFIX= ${LUA_PKGNAMEPREFIX}
@ -12,8 +12,6 @@ DISTNAME= lua-${PORTNAME}-${PORTVERSION}
MAINTAINER= feld@FreeBSD.org MAINTAINER= feld@FreeBSD.org
COMMENT= Iconv binding for Lua 5 COMMENT= Iconv binding for Lua 5
BROKEN_aarch64= fails to link: can't create dynamic relocation R_AARCH64_ABS64 against local symbol in readonly segment defined in iconv.lo
USES= pkgconfig iconv lua:51 USES= pkgconfig iconv lua:51
USE_GITHUB= yes USE_GITHUB= yes
@ -24,7 +22,9 @@ PLIST_FILES= %%LUA_MODLIBDIR%%/iconv.so
CFLAGS+= `pkgconf --cflags lua-${LUA_VER}` -I${LOCALBASE}/include CFLAGS+= `pkgconf --cflags lua-${LUA_VER}` -I${LOCALBASE}/include
MAKE_ARGS= LUABIN=${LUA_CMD} CFLAGS="${CFLAGS}" MAKE_ARGS= LUABIN=${LUA_CMD} CFLAGS="${CFLAGS}"
LDFLAGS= -shared ${ICONV_LIB} -L${LOCALBASE}/lib LDFLAGS= -shared ${ICONV_LIB} -L${LOCALBASE}/lib
CFLAGS_aarch64= -fPIC
CFLAGS_amd64= -fPIC CFLAGS_amd64= -fPIC
CFLAGS_i386= -fPIC
do-install: do-install:
@${MKDIR} ${STAGEDIR}${LUA_MODLIBDIR} @${MKDIR} ${STAGEDIR}${LUA_MODLIBDIR}