sync/ports
1
0
Fork 0
mirror of https://git.freebsd.org/ports.git synced 2025-07-18 17:59:20 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

math/givaro: fix build with clang 19

Browse source 
Clang 19 has become more strict about errors in member functions, which
results in errors building math/givaro:

  ./givaro/givaro/givaro/random-integer.h:94:51: error: no viable overloaded '='
     94 |                 const_cast<Integer_Domain&>(_ring)=R._ring;
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
  ./givaro/givaro/givaro/random-integer.h:94:51: note: type 'Integer_Domain' (aka 'ZRing<Integer>') is incomplete
     94 |                 const_cast<Integer_Domain&>(_ring)=R._ring;
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
  In file included from givintprime.C:19:
  In file included from ./givaro/givintprime.h:24:
  In file included from ./givaro/givaro/givinteger.h:25:
  ../../../src/kernel/ring/givaro/zring.h:123:13: warning: misleading indentation; statement is not part of the previous 'while' [-Wmisleading-indentation]
    123 |             return a; }
        |             ^
  ../../../src/kernel/ring/givaro/zring.h:121:11: note: previous statement is here
    121 |         { while (isZero(init(a, g())))
        |           ^

The `const_cast` line has been removed by upstream as part of
https://github.com/linbox-team/givaro/commit/b0cf33e1, but that commit
is rather large. It is enough to only delete the line.

Also fix a failure that occurs when running "make test":

  ../src/kernel/recint/rfiddling.h:170:29: error: no member named 'Low' in 'rint<K>'

This is because the expression `max.Low.Value` should actually be
`max.Value.Low`.

PR:		282830
Approved by:	pi (maintainer)
MFH:		2024Q4
This commit is contained in:
Dimitry Andric 2024-11-18 11:12:37 +01:00
parent be87c08770
commit b47d453f0a
2 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
math/givaro/files/patch-src_kernel_integer_random-integer.h Normal file
View file

@ -0,0 +1,10 @@
--- src/kernel/integer/random-integer.h.orig 2021-12-14 10:00:03 UTC
+++ src/kernel/integer/random-integer.h
@@ -91,7 +91,6 @@ namespace Givaro
if (this != &R) {
_bits = R._bits;
_integer = R._integer;
- const_cast<Integer_Domain&>(_ring)=R._ring;
}
return *this;
}

11
math/givaro/files/patch-src_kernel_recint_rfiddling.h Normal file
View file

@ -0,0 +1,11 @@
--- src/kernel/recint/rfiddling.h.orig 2021-12-14 10:00:03 UTC
+++ src/kernel/recint/rfiddling.h
@@ -167,7 +167,7 @@ namespace RecInt
template <size_t K>
inline rint<K> rint<K>::maxFFLAS() {
rint<K> max;
- set_highest_bit(max.Low.Value);
+ set_highest_bit(max.Value.Low);
return max;
}