www/nextcloud: Update to 13.0.1

- Includes breaking rename of $WWWDIR/apps path
 - Add fix file and warnings
 - Add OpCache option
 - Alphabetic ordering
 - Migration from ownCloud is stale
 - Take maintainership

PR:             227133
Approved by:    Loic Blot <loic blot unix-experience fr> (maintainer)

UPDATING

@@ -5,6 +5,18 @@ they are unavoidable.
 You should get into the habit of checking this file for changes each time
 you update your ports collection, before attempting any port upgrades.
 
+20180404:
+  AFFECTS: users of www/nextcloud
+  AUTHOR: brnrd@FreeBSD.org
+
+  With the 13.0.1 update the path for Apps bundled with the package has
+  changed from "apps" to "apps-pkg". You must add an entry to the
+  "apps_paths" array in config/config.php of your nextcloud installation,
+  a patch for the default installation can be applied with:
+
+  # cd /usr/local/www/nextcloud
+  # su -m www -c "php ./occ config:import < /usr/local/share/nextcloud/fix-apps_paths.json
+
 20180401:
   AFFECTS: users of mail/dovecot and mail/dovecot-pigeonhole
   AUTHOR: adamw@FreeBSD.org

www/nextcloud/Makefile

@@ -1,11 +1,11 @@
 # $FreeBSD$
 
 PORTNAME=	nextcloud
-DISTVERSION=	13.0.0
+DISTVERSION=	13.0.1
 CATEGORIES=	www
 MASTER_SITES=	https://download.nextcloud.com/server/prereleases/
 
-MAINTAINER=	loic.blot@unix-experience.fr
+MAINTAINER=	brnrd@FreeBSD.org
 COMMENT=	Personal cloud which runs on your own server
 
 LICENSE=	AGPLv3
@@ -25,31 +25,37 @@ SUB_FILES=	pkg-message
 PLIST_SUB=	NEXTCLOUD_USERNAME=${NEXTCLOUD_USERNAME} \
 		NEXTCLOUD_GROUPNAME=${NEXTCLOUD_GROUPNAME}
 
-OPTIONS_DEFINE=	EXIF LDAP SMB SSL
+OPTIONS_DEFINE=	EXIF LDAP OPCACHE SMB SSL
 OPTIONS_MULTI=	DB
 OPTIONS_MULTI_DB=	MYSQL PGSQL SQLITE
-OPTIONS_DEFAULT=	EXIF LDAP MYSQL SMB SSL
+OPTIONS_DEFAULT=	EXIF LDAP MYSQL OPCACHE SMB SSL
 
 DB_DESC=	Database backend(s)
 EXIF_DESC=	Image rotation support
+OPCACHE_DESC=	Enable (Nextcloud recommended) OpCache
 
 EXIF_USE=	PHP=exif
 LDAP_USE=	PHP=ldap
 MYSQL_USES=	mysql
 MYSQL_USE=	PHP=pdo_mysql
+OPCACHE_USE=	PHP=opcache
 PGSQL_USES=	pgsql
 PGSQL_USE=	PHP=pdo_pgsql,pgsql
+SMB_RUN_DEPENDS=	${PECL_PKGNAMEPREFIX}smbclient>=0.9.0:net/pecl-smbclient@${PHP_FLAVOR}
 SQLITE_USE=	PHP=pdo_sqlite,sqlite3
-SMB_RUN_DEPENDS=	${PECL_PKGNAMEPREFIX}smbclient>=0.8.0:net/pecl-smbclient@${PHP_FLAVOR}
 SSL_USE=	PHP=openssl
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|/var/www/|${WWWDIR}|' ${WRKSRC}/config/config.sample.php
+	@${REINPLACE_CMD} -e 's|/var/www/${PORTNAME}|${WWWDIR}|' ${WRKSRC}/config/config.sample.php
+	@${MV} ${WRKSRC}/apps ${WRKSRC}/apps-pkg
 
 do-install:
 	@${MKDIR} -m 0755 ${STAGEDIR}${WWWDIR}
 	@cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}
 	@${RM} ${STAGEDIR}${WWWDIR}/updater/updater.phar
 	@${MKDIR} ${STAGEDIR}${WWWDIR}/data
+	@${MKDIR} ${STAGEDIR}${WWWDIR}/apps
+	@${MKDIR} ${STAGEDIR}${DATADIR}
+	${INSTALL_DATA} ${FILESDIR}/fix-apps_paths.json ${STAGEDIR}${DATADIR}/fix-apps_paths.json
 
 .include <bsd.port.mk>

www/nextcloud/distinfo

@@ -1,3 +1,3 @@
-TIMESTAMP = 1517914004
-SHA256 (nextcloud-13.0.0.tar.bz2) = 38e6064432a2d1a044f219028d3fd46cb7a943a47e11eef346810bd289705aec
-SIZE (nextcloud-13.0.0.tar.bz2) = 43397247
+TIMESTAMP = 1521629500
+SHA256 (nextcloud-13.0.1.tar.bz2) = 5743314a71e972ae46a14b36b37394d4545915aa5f32d9e12ba786d04c1f1d11
+SIZE (nextcloud-13.0.1.tar.bz2) = 44183890

www/nextcloud/files/fix-apps_paths.json

@@ -0,0 +1,14 @@
+{"system": {"apps_paths":
+    [
+        {
+            "path": "\/usr\/local\/www\/nextcloud\/apps",
+            "url": "\/apps",
+            "writable": true
+        },
+        {
+            "path": "\/usr\/local\/www\/nextcloud\/apps-pkg",
+            "url": "\/apps-pkg",
+            "writable": false
+        }
+    ]
+}}

www/nextcloud/files/patch-config_config.sample.php

@@ -0,0 +1,14 @@
+--- config/config.sample.php.orig	2018-03-13 18:47:31 UTC
++++ config/config.sample.php
+@@ -818,6 +818,11 @@ $CONFIG = array(
+ 		'url' => '/apps',
+ 		'writable' => true,
+ 	),
++	array(
++		'path'=> '/var/www/nextcloud/apps-pkg',
++		'url' => '/var/www/apps-pkg',
++		'writable' => false,
++	),
+ ),
+ 
+ /**

www/nextcloud/files/pkg-message.in

@@ -1,19 +1,3 @@
-
-***********************************************************************
-*                         MIGRATION FROM OWNCLOUD                     *
-***********************************************************************
-
-If you are migrating from existing owncloud instance, you should do
-the following steps:
-
-- Copy/Move owncloud/data directory to nextcloud/data (don't forget
-        hidden files)
-- Copy/Move owncloud/config/config.php to nextcloud/config/config.php
-- Change the datadirectory in nextcloud/config/config.php
-- Ensure nextcloud/data and nextcloud/config/config.php are owned by 
-        www user and group
-
-
 ***********************************************************************
 *                         POST INSTALL CONFIGURATION                  *
 ***********************************************************************
@@ -39,5 +23,27 @@ And restart Apache.
 After a version migration you should upgrade your nextcloud instance
 using command line:
 
-* cd /usr/local/www/nextcloud
-* su -m www -c "php ./occ upgrade"
+  cd %%WWWDIR%%
+  su -m www -c "php ./occ upgrade"
+
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+                    /!\ NEXTCLOUD 13.0.1 UPDATE /!\
+
+The nextcloud 13.0.1 package changes the location of the bundled apps.
+After updating to 13.0.1 you MUST adapt your configuration. You MUST
+add an additional entry to the "apps-paths" array in config/config.php
+
+    1 =>
+    array (
+      'path' => '%%WWWDIR%%/apps-pkg',
+      'url' => '/apps-pkg',
+      'writable' => false,
+    ),
+
+For the default installation, the fix can be applied with:
+
+  cd %%WWWDIR%%
+  su -m www -c "php ./occ config:import < %%DATADIR%%/fix-apps_paths.json
+
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!