lang/sdcc: Update to 4.4.0

Remove the port options and just build everything because updating the
plist for each option is extremely tedious.
Add MAKE_JOBS_UNSAFE.
Switch to DISTVERSION.
Pet portfmt, portlint.

Changelog: https://sdcc.sourceforge.net/index.php#News

PR:		280609
Reported by:	Alexey Vyskubov <alexey@ocaml.nl>
Approved by:	submitter is maintainer

lang/sdcc/Makefile

@@ -1,7 +1,6 @@
 PORTNAME=	sdcc
-PORTVERSION=	4.0.0
+DISTVERSIONPREFIX=	src-
-DISTVERSIONPREFIX=src-
+DISTVERSION=	4.4.0
-PORTREVISION=	5
 CATEGORIES=	lang
 MASTER_SITES=	SF
 
@@ -14,54 +13,33 @@ LICENSE_COMB=	multi
 LICENSE_FILE_GPLv2=	${WRKSRC}/COPYING
 LICENSE_FILE_GPLv3=	${WRKSRC}/sdas/COPYING3
 
-BUILD_DEPENDS=	${LOCALBASE}/include/boost/graph/adjacency_list.hpp:devel/boost-libs
+BUILD_DEPENDS=	${LOCALBASE}/include/boost/graph/adjacency_list.hpp:devel/boost-libs \
+		gpasm:devel/gputils
+LIB_DEPENDS=	libzstd.so:archivers/zstd
 
-CONFLICTS_INSTALL=	sdcc sdcc-devel
+USES=		autoreconf:build bison compiler:c++11-lang gmake iconv \
-GNU_CONFIGURE=	yes
+		localbase python readline shebangfix tar:bzip2
-USES=		autoreconf:build bison compiler:c++11-lang gmake \
-		readline python shebangfix tar:bzip2
 SHEBANG_FILES=	support/scripts/as2gbmap.py
-TEST_WRKSRC=	${WRKSRC}/support/regression
+
+GNU_CONFIGURE=	yes
+CONFIGURE_ARGS=	--enable-non-free \
+		docdir=${DOCSDIR}
+
+MAKE_JOBS_UNSAFE=	yes
+
 TEST_ARGS=	--no-print-directory # tons of them, way too annoying
 TEST_TARGET=	all
 
-OPTIONS_DEFINE=		SDCCLIB DEVLIB DOCS UCSIM
+CONFLICTS_INSTALL=	sdcc sdcc-devel
-OPTIONS_MULTI=		TARGETS
-OPTIONS_MULTI_TARGETS=	HC08 MCS51 PADAUK PIC STM8 Z80
-OPTIONS_DEFAULT=	SDCCLIB DEVLIB UCSIM HC08 MCS51 PADAUK PIC STM8 Z80
 
-# XXX libsdcc does not build correctly without this.
+TEST_WRKSRC=	${WRKSRC}/support/regression
-SDCCLIB_IMPLIES=MCS51
+WRKSRC=		${WRKDIR}/sdcc-${DISTVERSION}
 
-SDCCLIB_DESC=	Standard C library (libsdcc)
+PLIST_SUB=	CONFIGURE_TARGET=${CONFIGURE_TARGET}
-DEVLIB_DESC=	Device libraries
-HC08_DESC=	Freescale 68HC08/S08
-MCS51_DESC=	Intel MCS51, Maxim DS80C390/DS80C400
-PADAUK_DESC=	Padauk PDK14/PDK15
-PIC_DESC=	Microchip PIC
-STM8_DESC=	STMicroelectronics STM8
-UCSIM_DESC=	The ucSim simulator
-Z80_DESC=	Zilog Z80/Z180/GBZ80, Rabbit 2000/3000, Toshiba TLCS-90
-
-CONFIGURE_ARGS=	--enable-non-free \
-		docdir=${DOCSDIR}
 PORTDOCS=	*
-WRKSRC=		${WRKDIR}/sdcc-${PORTVERSION}
 
-OPTIONS_SUB=		yes
+OPTIONS_DEFINE=		DOCS
-DEVLIB_CONFIGURE_OFF=	--disable-device-lib
+OPTIONS_DEFAULT=	DOCS
-HC08_CONFIGURE_OFF=	--disable-hc08-port --disable-s08-port
-MCS51_CONFIGURE_OFF=	--disable-ds390-port --disable-ds400-port	\
-			--disable-mcs51-port
-PADAUK_CONFIGURE_OFF=	--disable-pdk14-port --disable-pdk15-port
-PIC_BUILD_DEPENDS=	gputils>=1.2.0:devel/gputils
-PIC_RUN_DEPENDS=	gpasm:devel/gputils
-PIC_CONFIGURE_OFF=	--disable-pic14-port --disable-pic16-port
-STM8_CONFIGURE_OFF=	--disable-stm8-port
-UCSIM_CONFIGURE_OFF=	--disable-ucsim
-Z80_CONFIGURE_OFF=	--disable-gbz80-port --disable-r2k-port		\
-			--disable-r3ka-port --disable-tlcs90-port	\
-			--disable-z180-port --disable-z80-port
 
 .include <bsd.port.options.mk>
 
@@ -76,15 +54,40 @@ post-patch:
 		${WRKSRC}/support/sdbinutils/libiberty/Makefile.in
 	@${REINPLACE_CMD} '/^SUBDIRS =/s/doc//' \
 		${WRKSRC}/support/sdbinutils/bfd/Makefile.in
+	@${REINPLACE_CMD} 's/[[:<:]]ARCH[[:>:]]/PICARCH/g' \
+		${WRKSRC}/device/lib/pic14/Makefile.common \
+		${WRKSRC}/device/lib/pic14/Makefile.in \
+		${WRKSRC}/device/lib/pic14/configure \
+		${WRKSRC}/device/lib/pic14/configure.ac \
+		${WRKSRC}/device/lib/pic14/libc/Makefile.in \
+		${WRKSRC}/device/lib/pic14/libm/Makefile.in \
+		${WRKSRC}/device/lib/pic14/libsdcc/enhanced/Makefile.in \
+		${WRKSRC}/device/lib/pic14/libsdcc/enhanced-no-xinst/Makefile.in \
+		${WRKSRC}/device/lib/pic14/libsdcc/regular/Makefile.in \
+		${WRKSRC}/device/lib/pic16/Makefile.in \
+		${WRKSRC}/device/lib/pic16/configure \
+		${WRKSRC}/device/lib/pic16/configure.ac \
+		${WRKSRC}/device/lib/pic16/debug/Makefile.in \
+		${WRKSRC}/device/lib/pic16/libc/Makefile.in \
+		${WRKSRC}/device/lib/pic16/libio/Makefile.in \
+		${WRKSRC}/device/lib/pic16/libm/Makefile.in \
+		${WRKSRC}/device/lib/pic16/libsdcc/Makefile.in \
+		${WRKSRC}/device/lib/pic16/startup/Makefile.in \
+		${WRKSRC}/device/non-free/lib/pic14/Makefile.common.in \
+		${WRKSRC}/device/non-free/lib/pic14/Makefile.rules \
+		${WRKSRC}/device/non-free/lib/pic16/Makefile.in \
+		${WRKSRC}/device/non-free/lib/pic16/configure \
+		${WRKSRC}/device/non-free/lib/pic16/configure.ac \
+		${WRKSRC}/device/non-free/lib/pic16/libdev/Makefile.in \
+		${WRKSRC}/device/non-free/lib/pic16/libdev/mkmk.sh
+	@${REINPLACE_CMD} 's/[[:<:]]arch[[:>:]]/picarch/g' \
+		${WRKSRC}/device/non-free/lib/pic16/libdev/mkmk.sh
 
 post-patch-DOCS-off:
 	@${REINPLACE_CMD} 's, [a-z-]*doc,,' \
 		${WRKSRC}/Makefile.in \
 		${WRKSRC}/sim/ucsim/packages_in.mk
 
-pre-configure:
-	cd ${WRKSRC}/device/lib/pic14 && ${AUTORECONF} -f -i
-
 post-install:
 	${FIND} -d ${STAGEDIR}${DATADIR} -type d -empty -delete
 

lang/sdcc/distinfo

@@ -1,3 +1,3 @@
-TIMESTAMP = 1580406957
+TIMESTAMP = 1722947046
-SHA256 (sdcc-src-4.0.0.tar.bz2) = 489180806fc20a3911ba4cf5ccaf1875b68910d7aed3f401bbd0695b0bef4e10
+SHA256 (sdcc-src-4.4.0.tar.bz2) = ae8c12165eb17680dff44b328d8879996306b7241efa3a83b2e3b2d2f7906a75
-SIZE (sdcc-src-4.0.0.tar.bz2) = 19204540
+SIZE (sdcc-src-4.4.0.tar.bz2) = 20036262

lang/sdcc/files/patch-device-lib-Makefile.in

@@ -1,18 +1,19 @@
---- device/lib/Makefile.in.orig	2019-09-30 09:10:08 UTC
+--- device/lib/Makefile.in.orig	2023-11-07 18:56:44 UTC
 +++ device/lib/Makefile.in
-@@ -590,29 +590,7 @@ clean_intermediate-pic14:
+@@ -668,30 +668,7 @@ clean_intermediate-pic14:
  # ---------------------------------------------------
  install: all installdirs
  	[ ! -d "$(BUILDDIR)" ] || $(CP_U) -r $(BUILDDIR)/* $(sdcc_libdir)
 -	$(CP_U) -r $(MODELS) $(srcdir)/mcs51 $(srcdir)/ds390 $(srcdir)/ds400 \
--	                     $(srcdir)/z80 $(srcdir)/z180 $(srcdir)/ez80_z80 $(srcdir)/r2k $(srcdir)/r3ka $(srcdir)/tlcs90 $(srcdir)/gbz80 \
+-	                     $(srcdir)/z80 $(srcdir)/z180 $(srcdir)/ez80_z80 $(srcdir)/z80n $(srcdir)/r2k $(srcdir)/r2ka $(srcdir)/r3ka $(srcdir)/tlcs90 $(srcdir)/sm83 $(srcdir)/r800 \
 -	                     $(srcdir)/hc08 $(srcdir)/s08 \
+-	                     $(srcdir)/mos6502 $(srcdir)/mos65c02 \
 -	                     $(srcdir)/stm8 \
 -	                     $(srcdir)/pdk13 $(srcdir)/pdk14 $(srcdir)/pdk15 \
 -	                     $(srcdir)/pic14 $(srcdir)/pic16 $(srcdir)/*.c $(sdcc_libdir)/src
--	$(CP_U) -r $(MODELS) mcs51 ds390 ds400 z80 z180 ez80_z80 r2k r3ka tlcs90 gbz80 hc08 s08 stm8 pdk13 pdk14 pdk15 $(sdcc_libdir)/src
+-	$(CP_U) -r $(MODELS) mcs51 ds390 ds400 z80 z180 ez80_z80 z80n r2k r2ka r3ka tlcs90 sm83 r800 hc08 s08 stm8 pdk13 pdk14 pdk15 $(sdcc_libdir)/src
  
--	for src in $(MODELS) ds390 ds400 z80 z180 ez80_z80 r2k r3ka tlcs90 gbz80 hc08 s08 stm8 pdk13 pdk14 pdk15 pic14 pic16; do \
+-	for src in $(MODELS) ds390 ds400 z80 z180 ez80_z80 z80n r2k r2ka r3ka tlcs90 sm83 r800 hc08 s08 mos6502 mos65c02 stm8 pdk13 pdk14 pdk15 pic14 pic16; do \
 -	  find $(sdcc_libdir)/src/$$src -depth \
 -	    \( -name '*.rel' -o -name '*.dump*' -o -name '*.sym' -o -name '*.o' -o -name '*.lib' -o \
 -	    -name '*.lst' -o -name '*.asm' -o -name '.svn' -o -name 'autom4te.cache' -o \
@@ -30,7 +31,7 @@
  # Deleting all the installed files
  # --------------------------------
  uninstall:
-@@ -631,12 +609,6 @@ installcheck:
+@@ -710,12 +687,6 @@ installcheck:
  # Creating installation directories
  # ---------------------------------
  installdirs: