sync/ports
1
0
Fork 0
mirror of https://git.freebsd.org/ports.git synced 2025-07-18 01:39:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Mk/Scripts/qa.sh: Turn off pipefail when piping to grep -q

Browse source 
The pipeline

   readelf -d "${dep_file}" | grep -q SONAME

can fail because grep -q closes the output early resulting sigpipe being
sent to readelf.  Other possible solutions are to turn off pipefail for
the file or remove the -q grep argument.

Credit to ashish@ for the detective work to discover the root cause of
this.

Differential Revision: https://reviews.freebsd.org/D31211

Reviewed by:	emaste
Approved by:	bapt (portmgr) mat (portmgr)
This commit is contained in:
Joseph Mingrone 2021-07-17 12:55:13 -03:00
parent 8e05a6e24d
commit 6ff48ecff7
No known key found for this signature in database
GPG key ID: 36A40C83B0D6EF9E
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Mk/Scripts/qa.sh
View file

@ -663,9 +663,13 @@ proxydeps() {
# Check that the .so we need has a SONAME # Check that the .so we need has a SONAME
if [ "${dep_file_pkg}" != "${PKGORIGIN}" ]; then if [ "${dep_file_pkg}" != "${PKGORIGIN}" ]; then
# When grep -q finds a match it will close the pipe immediately.
# This may cause the test to fail when pipefail is turned on.
set +o pipefail
if ! readelf -d "${dep_file}" | grep -q SONAME; then if ! readelf -d "${dep_file}" | grep -q SONAME; then
err "${file} is linked to ${dep_file} which does not have a SONAME. ${dep_file_pkg} needs to be fixed." err "${file} is linked to ${dep_file} which does not have a SONAME. ${dep_file_pkg} needs to be fixed."
fi fi
set -o pipefail
fi fi
# If we don't already depend on it, and we don't provide it # If we don't already depend on it, and we don't provide it