From 4d5d01f42f436a1834773cc616fb7a693acfbc74 Mon Sep 17 00:00:00 2001 From: Dimitry Andric Date: Wed, 4 Dec 2024 19:49:29 +0100 Subject: [PATCH] security/heimdal: fix with stock clang >= 16 Upstream clang >= 16 made -Wimplicit-function-declaration into an error by default. In the base system, this change was reverted to reduce the fallout in ports, because there are many problematic configure scripts. For security/heimdal this also applies, so for building the port with devel/llvm16 or higher we need to add -Wno-implicit-function-declaration to CFLAGS. While here, use LDFLAGS+= for -Wl,--undefined-version, to avoid overwriting any user-specified LDFLAGS. PR: 283131 Approved by: maintainer timeout (2 weeks) MFH: 2025Q1 --- security/heimdal/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/heimdal/Makefile b/security/heimdal/Makefile index 3508ad2f8f0c..dae850e063f3 100644 --- a/security/heimdal/Makefile +++ b/security/heimdal/Makefile @@ -45,7 +45,8 @@ CONFIGURE_ARGS= --with-berkeley-db \ --sysconfdir="${PREFIX}/etc" # XXX --with-readline picks up libreadline even if found in /usr/lib. MAKE_ENV= INSTALL_CATPAGES=no -LDFLAGS= -Wl,--undefined-version +CFLAGS+= -Wno-implicit-function-declaration +LDFLAGS+= -Wl,--undefined-version INSTALL_TARGET= install-strip .if !exists(/etc/rc.d/ipropd_master) USE_RC_SUBR= ipropd_master ipropd_slave