From 32685f33bfec2fa55a60956a0ab39e8949921c9c Mon Sep 17 00:00:00 2001 From: Siva Mahadevan Date: Wed, 16 Apr 2025 20:56:40 +0300 Subject: [PATCH] graphics/xsane: Cleanup RUN_DEPENDS=BUILD_DEPENDS antipattern Section 5.10.2 of the Porter's handbook states that setting RUN_DEPENDS=${BUILD_DEPENDS} directly is an antipattern and gives guidance on how to avoid it. PR: 283227 --- graphics/xsane/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/graphics/xsane/Makefile b/graphics/xsane/Makefile index 4f3f368a2655..eaf8e2735e9e 100644 --- a/graphics/xsane/Makefile +++ b/graphics/xsane/Makefile @@ -10,12 +10,13 @@ WWW= https://gitlab.com/sane-project/frontend/xsane LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/xsane.COPYING -BUILD_DEPENDS= scanimage:graphics/sane-backends +BR_DEPENDS= scanimage:graphics/sane-backends +BUILD_DEPENDS= ${BR_DEPENDS} LIB_DEPENDS= libpng.so:graphics/png \ libtiff.so:graphics/tiff \ libfreetype.so:print/freetype2 \ liblcms.so:graphics/lcms -RUN_DEPENDS:= ${BUILD_DEPENDS} +RUN_DEPENDS= ${BR_DEPENDS} USES= gmake gnome jpeg localbase:ldflags pkgconfig USE_GITLAB= yes