From 15c5abdbf4428d7144220a8f5d663cf9dc33d8ff Mon Sep 17 00:00:00 2001
From: Muhammad Moinur Rahman <bofh@FreeBSD.org>
Date: Sat, 5 Aug 2023 21:21:10 +0200
Subject: [PATCH] emulators/vba: Fix build with llvm16

- Utilize USES=localbase
- Pet portclippy

Approved by:	portmgr (blanket)
Sponsored by:	The FreeBSD Foundation
---
 emulators/vba/Makefile | 40 +++++++++++++++++++---------------------
 1 file changed, 19 insertions(+), 21 deletions(-)

diff --git a/emulators/vba/Makefile b/emulators/vba/Makefile
index 9ee1af5f39ef..730b401a362b 100644
--- a/emulators/vba/Makefile
+++ b/emulators/vba/Makefile
@@ -12,41 +12,39 @@ WWW=		https://web.archive.org/web/20110718045837/http://vba.ngemu.com/
 LICENSE=	GPLv2+
 LICENSE_FILE=	${WRKSRC}/COPYING
 
-BUILD_DEPENDS=	nasm:devel/nasm
-LIB_DEPENDS=	libpng.so:graphics/png
-
 BROKEN_powerpc=		Runaway cc1plus process
 BROKEN_sparc64=		Runaway cc1plus process
 
-USES=		gettext gmake sdl
-GNU_CONFIGURE=	yes
+BUILD_DEPENDS=	nasm:devel/nasm
+LIB_DEPENDS=	libpng.so:graphics/png
+
+USES=		gettext gmake localbase sdl
+USE_CXXSTD=	c++14
 USE_SDL=	sdl
 
-CPPFLAGS+=	-I${LOCALBASE}/include
-LIBS+=		-L${LOCALBASE}/lib -lintl
+GNU_CONFIGURE=	yes
+
+LIBS+=		-lintl
 
-WRKSRC=		${WRKDIR}/VisualBoyAdvance-${PORTVERSION}
 SUB_FILES=	pkg-message
 
-DATA_FILES=	${WRKSRC}/src/VisualBoyAdvance.cfg
-PROG_FILES=	${WRKSRC}/src/sdl/VisualBoyAdvance
+WRKSRC=		${WRKDIR}/VisualBoyAdvance-${PORTVERSION}
+
 PORTDOCS=	AUTHORS NEWS README ChangeLog
 
 OPTIONS_DEFINE=	DOCS GTK2 PROFILING
 OPTIONS_SUB=	yes
 PROFILING_DESC=	Enable profiling
 
-GTK2_CONFIGURE_ON=	--enable-gtk=2.4
 GTK2_LIB_DEPENDS=	libglademm-2.4.so:devel/libglademm24
 GTK2_USES=		pkgconfig
+GTK2_CONFIGURE_ON=	--enable-gtk=2.4
+GTK2_VARS=	PROG_FILES+=${WRKSRC}/src/gtk/gvba \
+		GTK2_DATA_FILES=${WRKSRC}/src/gtk/vba.glade
 PROFILING_CONFIGURE_ENABLE=	profiling
 
-.include <bsd.port.options.mk>
-
-.if ${PORT_OPTIONS:MGTK2}
-PROG_FILES+=		${WRKSRC}/src/gtk/gvba
-GTK2_DATA_FILES=	${WRKSRC}/src/gtk/vba.glade
-.endif
+DATA_FILES=	${WRKSRC}/src/VisualBoyAdvance.cfg
+PROG_FILES=	${WRKSRC}/src/sdl/VisualBoyAdvance
 
 post-patch:
 	@${REINPLACE_CMD} -e '/for(int i = 0; i < 16; i++/s| i|&_|g' \
@@ -57,12 +55,12 @@ do-install:
 	${SED} -e 's|filter=0|filter=1|' ${DATA_FILES} > ${DATA_FILES}-default
 	${INSTALL_DATA} ${DATA_FILES}-default ${STAGEDIR}${PREFIX}/bin
 
-do-install-GTK2-on:
-	@${MKDIR} ${STAGEDIR}${PREFIX}/share/VisualBoyAdvance
-	${INSTALL_DATA} ${GTK2_DATA_FILES} ${STAGEDIR}${PREFIX}/share/VisualBoyAdvance
-
 do-install-DOCS-on:
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
+do-install-GTK2-on:
+	@${MKDIR} ${STAGEDIR}${PREFIX}/share/VisualBoyAdvance
+	${INSTALL_DATA} ${GTK2_DATA_FILES} ${STAGEDIR}${PREFIX}/share/VisualBoyAdvance
+
 .include <bsd.port.mk>