Change to REQUIRE: LOGIN, and remove a default empty variable assignment [1]

While I'm here, perform a few other should-be-noop cleanups

Approved by:	maintainer [1]

sysutils/atop/Makefile

@@ -7,6 +7,7 @@
 
 PORTNAME=	atop
 PORTVERSION=	1.26.b4
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	${MASTER_SITE_BERLIOS}
 MASTER_SITE_SUBDIR=atop-freebsd

sysutils/atop/files/atop.in

@@ -1,25 +1,32 @@
 #!/bin/sh
+
 # $FreeBSD$
-
+#
 # PROVIDE: atop
-# REQUIRE: DAEMON
-# BEFORE: LOGIN
+# REQUIRE: LOGIN
 # KEYWORD: shutdown
-
+#
 # Define these atop_* variables in one of these files:
 #       /etc/rc.conf
 #       /etc/rc.conf.local
 #       /etc/rc.conf.d/atop
 #
 # DO NOT CHANGE THESE DEFAULT VALUES HERE
-#
-atop_enable="${atop_enable-NO}"
-atop_pidfile="/var/run/atop.pid"
 
 . /etc/rc.subr
 
 name="atop"
 rcvar=`set_rcvar`
+
+load_rc_config $name
+
+: ${atop_enable:=NO}
+: ${atop_logdir="%%LOGDIR%%"}
+: ${atop_interval=10}
+: ${atop_keepdays=30}
+
+pidfile="${atop_pidfile:-'/var/run/atop.pid'}"
+
 command="%%PREFIX%%/bin/atop"
 extra_commands="rotate"
 start_cmd="atop_start"
@@ -46,13 +53,4 @@ atop_rotate()
     run_rc_command "restart"
 }
 
-load_rc_config $name
-
-: ${atop_logdir="%%LOGDIR%%"}
-: ${atop_interval=10}
-: ${atop_keepdays=30}
-: ${atop_flags=""}
-
-pidfile="${atop_pidfile}"
-
 run_rc_command "$1"